From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 18 May 2018 08:10:41 +0000 Subject: [PATCH] drm/v3d: Checking for NULL vs IS_ERR() Message-Id: <20180518081041.GC28335@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Eric Anholt Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org The v3d_fence_create() only returns error pointers on error. It never returns NULL. Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sched.c index b07bece9417d..808bc901f567 100644 --- a/drivers/gpu/drm/v3d/v3d_sched.c +++ b/drivers/gpu/drm/v3d/v3d_sched.c @@ -114,8 +114,8 @@ static struct dma_fence *v3d_job_run(struct drm_sched_job *sched_job) v3d_invalidate_caches(v3d); fence = v3d_fence_create(v3d, q); - if (!fence) - return fence; + if (IS_ERR(fence)) + return NULL; if (job->done_fence) dma_fence_put(job->done_fence); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm/v3d: Checking for NULL vs IS_ERR() Date: Fri, 18 May 2018 11:10:41 +0300 Message-ID: <20180518081041.GC28335@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7CBD76EC96 for ; Fri, 18 May 2018 08:10:55 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhlIHYzZF9mZW5jZV9jcmVhdGUoKSBvbmx5IHJldHVybnMgZXJyb3IgcG9pbnRlcnMgb24gZXJy b3IuICBJdCBuZXZlcgpyZXR1cm5zIE5VTEwuCgpGaXhlczogNTc2OTJjOTRkY2JlICgiZHJtL3Yz ZDogSW50cm9kdWNlIGEgbmV3IERSTSBkcml2ZXIgZm9yIEJyb2FkY29tIFYzRCBWMy54KyIpClNp Z25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KCmRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vdjNkL3YzZF9zY2hlZC5jIGIvZHJpdmVycy9ncHUv ZHJtL3YzZC92M2Rfc2NoZWQuYwppbmRleCBiMDdiZWNlOTQxN2QuLjgwOGJjOTAxZjU2NyAxMDA2 NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL3YzZC92M2Rfc2NoZWQuYworKysgYi9kcml2ZXJzL2dw dS9kcm0vdjNkL3YzZF9zY2hlZC5jCkBAIC0xMTQsOCArMTE0LDggQEAgc3RhdGljIHN0cnVjdCBk bWFfZmVuY2UgKnYzZF9qb2JfcnVuKHN0cnVjdCBkcm1fc2NoZWRfam9iICpzY2hlZF9qb2IpCiAJ djNkX2ludmFsaWRhdGVfY2FjaGVzKHYzZCk7CiAKIAlmZW5jZSA9IHYzZF9mZW5jZV9jcmVhdGUo djNkLCBxKTsKLQlpZiAoIWZlbmNlKQotCQlyZXR1cm4gZmVuY2U7CisJaWYgKElTX0VSUihmZW5j ZSkpCisJCXJldHVybiBOVUxMOwogCiAJaWYgKGpvYi0+ZG9uZV9mZW5jZSkKIAkJZG1hX2ZlbmNl X3B1dChqb2ItPmRvbmVfZmVuY2UpOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK