All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] qemu-iotests: Filter NFS paths
Date: Fri, 18 May 2018 10:42:21 +0200	[thread overview]
Message-ID: <20180518084221.GA4833@localhost.localdomain> (raw)
In-Reply-To: <20180517165253.19958-3-kwolf@redhat.com>

Am 17.05.2018 um 18:52 hat Kevin Wolf geschrieben:
> NFS paths were only partially filtered in _filter_img_create, _img_info
> and _filter_img_info, resulting in "nfs://127.0.0.1TEST_DIR/t.IMGFMT".
> This adds another replacement to the sed calls that matches $TEST_IMG as
> a whole.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Self-NACK, this replaces a bit too much... (Some places in the test
scripts override $TEST_IMG, but not $TEST_IMG_FILE).

Maybe we need to introduce some $TEST_DIR_REMOTE (any suggestions for
a better name?) that would contain "nfs://127.0.0.1$TEST_DIR" and can be
used in the filter function.

Kevin

  reply	other threads:[~2018-05-18  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17 16:52 [Qemu-devel] [PATCH 0/3] qemu-iotests: Fix NFS + raw Kevin Wolf
2018-05-17 16:52 ` [Qemu-devel] [PATCH 1/3] qemu-iotests: Fix paths for NFS Kevin Wolf
2018-05-17 16:52 ` [Qemu-devel] [PATCH 2/3] qemu-iotests: Filter NFS paths Kevin Wolf
2018-05-18  8:42   ` Kevin Wolf [this message]
2018-05-17 16:52 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: 086 doesn't work with NFS Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180518084221.GA4833@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.