From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH V5] nvmet: add simple file backed ns support
Date: Fri, 18 May 2018 11:06:33 +0200 [thread overview]
Message-ID: <20180518090633.GD24436@lst.de> (raw)
In-Reply-To: <BN6PR04MB1203154BDE61CFAD7ED095D986910@BN6PR04MB1203.namprd04.prod.outlook.com>
> > +???? ns->cachep = kmem_cache_create("nvmet-fs",
>
> what about nvmet-bvec as the name?
>
> [CK] Also, while we are at it should I change the name of the?
> following functions?currently present?in the io-cmd.c and add
> suffix "bdev" ?
Sounds good to me. And please use bdev everywhere instead of blk
or blkdev.
>
> 1.?nvmet_execute_write_zeroes
> 2. nvmet_execute_dsm
> 3. nvmet_execute_discard
> 4. nvmet_discard_range
> 5 .nvmet_discard_range
> 6. nvmet_execute_rw
nvmet_bdev_*
> [CK] Here we only issue sync I/O when nr_bvec > NVMET_MAX_MEMPOOL_BVEC, when
> nr_bvec <=?NVMET_MAX_MEMPOOL_BVEC and we still allocate from mempool which
> will result in?async I/O. We have to make this allocation info (mempool vs kmalloc_arrat)
> accessible in the?callback function by?adding a new member to the struct nvmet_req
> anonymous union.
Sounds good.
> Instead of adding a new member, since we are under memory pressure here can
> we set is_sync unconditionally when we allocate from the mempool and force sync I/O?
I don't think that makes sense. A lot of I/Os under memory pressure
are probably small, and there is no need to slow them down for no good
reason.
prev parent reply other threads:[~2018-05-18 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 5:45 [PATCH V5] nvmet: add simple file backed ns support Chaitanya Kulkarni
2018-05-17 12:47 ` Christoph Hellwig
2018-05-17 21:14 ` Keith Busch
2018-05-17 22:39 ` Chaitanya Kulkarni
2018-05-18 9:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518090633.GD24436@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.