All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 6/7] support/scripts/pkg-stats: add CPE reporting
Date: Fri, 18 May 2018 09:13:46 +0200	[thread overview]
Message-ID: <20180518091346.40263aea@windsurf> (raw)
In-Reply-To: <1526613200-48452-7-git-send-email-matthew.weber@rockwellcollins.com>

Hello,

On Thu, 17 May 2018 22:13:19 -0500, Matt Weber wrote:

>      packages = get_pkglist(args.npackages, package_list)
> -    print "Getting package make info ..."
> +    print("Getting package make info ...")
>      package_init_make_info()
> -    print "Getting package details ..."
> +    print("Getting package details ...")
>      for pkg in packages:
>          pkg.set_infra()
>          pkg.set_license()
> @@ -517,9 +584,10 @@ def __main__():
>          pkg.set_patch_count()
>          pkg.set_check_package_warnings()
>          pkg.set_current_version()
> -    print "Calculate stats"
> +        pkg.set_cpe_info(cpedb)
> +    print("Calculate stats")
>      stats = calculate_stats(packages)
> -    print "Write HTML"
> +    print("Write HTML")

I hate silly reviews, and this is a silly review, but this change to
use parenthesis in print calls is not related to introducing CPE
support, so it should be a separate patch (which I could merge sooner
and separately from the CPE discussion).

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-18  7:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  3:13 [Buildroot] [PATCH v5 0/7] CPE ID Support Matt Weber
2018-05-18  3:13 ` [Buildroot] [PATCH v5 1/7] cpe-info: new make target Matt Weber
2018-05-18  3:13 ` [Buildroot] [PATCH v5 2/7] cpe-info: id prefix/suffix Matt Weber
2018-05-18  3:13 ` [Buildroot] [PATCH v5 3/7] cpe-info: only report target pkgs Matt Weber
2018-05-18  3:13 ` [Buildroot] [PATCH v5 4/7] cpe-info: update manual for new pkg vars Matt Weber
2018-05-18  3:13 ` [Buildroot] [PATCH v5 5/7] support/scripts/cpedb.py: new CPE XML helper Matt Weber
2018-05-18  3:13 ` [Buildroot] [PATCH v5 6/7] support/scripts/pkg-stats: add CPE reporting Matt Weber
2018-05-18  7:13   ` Thomas Petazzoni [this message]
2018-05-18 13:05     ` Matthew Weber
2018-05-18  3:13 ` [Buildroot] [PATCH v5 7/7] support/scripts/cpe-report: new script Matt Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180518091346.40263aea@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.