From: Igor Mammedov <imammedo@redhat.com>
To: Michael Clark <mjc@sifive.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Eric Blake" <eblake@redhat.com>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH v2] riscv: remove define cpu_init()
Date: Fri, 18 May 2018 10:02:14 +0200 [thread overview]
Message-ID: <20180518100214.5e14a753@redhat.com> (raw)
In-Reply-To: <CAHNT7NtoqQDpQCMF9C92KHvn6jLAy0K1fOJaT6nTTAAJ0s+utQ@mail.gmail.com>
On Fri, 18 May 2018 14:10:24 +1200
Michael Clark <mjc@sifive.com> wrote:
> On Wed, May 16, 2018 at 4:00 AM, Igor Mammedov <imammedo@redhat.com> wrote:
>
> > cpu_init() was removed since 2.12, so drop the define that is now unused.
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >
>
> Reviewed-by: Michael Clark <mjc@sifive.com>
Michael,
could you merge it through RISCV queue?
>
> ---
> > v2:
> > * refine commit message (Eric Blake <eblake@redhat.com>)
> > ---
> > target/riscv/cpu.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> > index 34abc38..0562a02 100644
> > --- a/target/riscv/cpu.h
> > +++ b/target/riscv/cpu.h
> > @@ -251,7 +251,6 @@ int riscv_cpu_handle_mmu_fault(CPUState *cpu, vaddr
> > address, int size,
> > char *riscv_isa_string(RISCVCPU *cpu);
> > void riscv_cpu_list(FILE *f, fprintf_function cpu_fprintf);
> >
> > -#define cpu_init(cpu_model) cpu_generic_init(TYPE_RISCV_CPU, cpu_model)
> > #define cpu_signal_handler cpu_riscv_signal_handler
> > #define cpu_list riscv_cpu_list
> > #define cpu_mmu_index riscv_cpu_mmu_index
> > --
> > 2.7.4
> >
> >
next prev parent reply other threads:[~2018-05-18 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 11:16 [Qemu-devel] [PATCH] riscv: remove define cpu_init() Igor Mammedov
2018-05-15 14:39 ` Philippe Mathieu-Daudé
2018-05-15 15:44 ` Eric Blake
2018-05-15 16:00 ` [Qemu-devel] [PATCH v2] " Igor Mammedov
2018-05-18 2:10 ` Michael Clark
2018-05-18 8:02 ` Igor Mammedov [this message]
2018-07-25 22:27 ` Michael Clark
2018-07-26 8:46 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518100214.5e14a753@redhat.com \
--to=imammedo@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=mjc@sifive.com \
--cc=palmer@sifive.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.