From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: EDAC, ghes: Make platform-based whitelisting x86-only From: Borislav Petkov Message-Id: <20180518112028.GD17285@pd.tnic> Date: Fri, 18 May 2018 13:20:28 +0200 To: James Morse Cc: Zhengqiang , Tyler Baicar , mchehab@kernel.org, toshi.kani@hpe.com, linux-edac@vger.kernel.org, linuxarm@huawei.com, "linux-arm-kernel@lists.infradead.org" List-ID: RnJvbTogQm9yaXNsYXYgUGV0a292IDxicEBzdXNlLmRlPgoKQVJNIG1hY2hpbmVzIGFsbCBoYXZl IERNSSB0YWJsZXMgc28gaWYgdGhleSByZXF1ZXN0IGh3IGVycm9yIHJlcG9ydGluZwp0aHJvdWdo IEdIRVMsIHRoZW4gdGhlIGRyaXZlciBzaG91bGQgYmUgYWJsZSB0byBkZXRlY3QgRElNTXMgYW5k IHJlcG9ydAplcnJvcnMgc3VjY2Vzc2Z1bGx5IChmYW1vdXMgbGFzdCB3b3JkcyA6KSkuCgpNYWtl IHRoZSBwbGF0Zm9ybS1iYXNlZCBsaXN0IHg4Ni1zcGVjaWZpYyBzbyB0aGF0IGdoZXNfZWRhYyBj YW4gbG9hZCBvbgpBUk0uCgpTaWduZWQtb2ZmLWJ5OiBCb3Jpc2xhdiBQZXRrb3YgPGJwQHN1c2Uu ZGU+ClJldmlld2VkLWJ5OiBKYW1lcyBNb3JzZSA8amFtZXMubW9yc2VAYXJtLmNvbT4KVGVzdGVk LWJ5OiBKYW1lcyBNb3JzZSA8amFtZXMubW9yc2VAYXJtLmNvbT4KQ2M6IFFpYW5nIFpoZW5nIDx6 aGVuZ3FpYW5nMTBAaHVhd2VpLmNvbT4KTGluazogaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci8x NTI2MDM5NTQzLTE4MDk5Ni0xLWdpdC1zZW5kLWVtYWlsLXpoZW5ncWlhbmcxMEBodWF3ZWkuY29t Ci0tLQogZHJpdmVycy9lZGFjL2doZXNfZWRhYy5jIHwgMTQgKysrKysrKysrLS0tLS0KIDEgZmls ZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv ZHJpdmVycy9lZGFjL2doZXNfZWRhYy5jIGIvZHJpdmVycy9lZGFjL2doZXNfZWRhYy5jCmluZGV4 IDg2M2ZiZjNkYjI5Zi4uNDczYWVlYzRiMWRhIDEwMDY0NAotLS0gYS9kcml2ZXJzL2VkYWMvZ2hl c19lZGFjLmMKKysrIGIvZHJpdmVycy9lZGFjL2doZXNfZWRhYy5jCkBAIC00NDAsMTIgKzQ0MCwx NiBAQCBpbnQgZ2hlc19lZGFjX3JlZ2lzdGVyKHN0cnVjdCBnaGVzICpnaGVzLCBzdHJ1Y3QgZGV2 aWNlICpkZXYpCiAJc3RydWN0IG1lbV9jdGxfaW5mbyAqbWNpOwogCXN0cnVjdCBlZGFjX21jX2xh eWVyIGxheWVyc1sxXTsKIAlzdHJ1Y3QgZ2hlc19lZGFjX2RpbW1fZmlsbCBkaW1tX2ZpbGw7Ci0J aW50IGlkeDsKKwlpbnQgaWR4ID0gLTE7CiAKLQkvKiBDaGVjayBpZiBzYWZlIHRvIGVuYWJsZSBv biB0aGlzIHN5c3RlbSAqLwotCWlkeCA9IGFjcGlfbWF0Y2hfcGxhdGZvcm1fbGlzdChwbGF0X2xp c3QpOwotCWlmICghZm9yY2VfbG9hZCAmJiBpZHggPCAwKQotCQlyZXR1cm4gLUVOT0RFVjsKKwlp ZiAoSVNfRU5BQkxFRChDT05GSUdfWDg2KSkgeworCQkvKiBDaGVjayBpZiBzYWZlIHRvIGVuYWJs ZSBvbiB0aGlzIHN5c3RlbSAqLworCQlpZHggPSBhY3BpX21hdGNoX3BsYXRmb3JtX2xpc3QocGxh dF9saXN0KTsKKwkJaWYgKCFmb3JjZV9sb2FkICYmIGlkeCA8IDApCisJCQlyZXR1cm4gLUVOT0RF VjsKKwl9IGVsc2UgeworCQlpZHggPSAwOworCX0KIAogCS8qCiAJICogV2UgaGF2ZSBvbmx5IG9u ZSBsb2dpY2FsIG1lbW9yeSBjb250cm9sbGVyIHRvIHdoaWNoIGFsbCBESU1NcyBiZWxvbmcuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: bp@alien8.de (Borislav Petkov) Date: Fri, 18 May 2018 13:20:28 +0200 Subject: [PATCH] EDAC, ghes: Make platform-based whitelisting x86-only In-Reply-To: <20180518111132.GC17285@pd.tnic> References: <1526039543-180996-1-git-send-email-zhengqiang10@huawei.com> <20180511121901.GA12705@pd.tnic> <5AF90C70.408@huawei.com> <20180514094709.GC23049@pd.tnic> <20180514164720.GH23049@pd.tnic> <20180516182958.GB17092@pd.tnic> <8602b133-e0fa-57e2-5159-9d34a1ded85f@arm.com> <20180518111132.GC17285@pd.tnic> Message-ID: <20180518112028.GD17285@pd.tnic> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Borislav Petkov ARM machines all have DMI tables so if they request hw error reporting through GHES, then the driver should be able to detect DIMMs and report errors successfully (famous last words :)). Make the platform-based list x86-specific so that ghes_edac can load on ARM. Signed-off-by: Borislav Petkov Reviewed-by: James Morse Tested-by: James Morse Cc: Qiang Zheng Link: https://lkml.kernel.org/r/1526039543-180996-1-git-send-email-zhengqiang10 at huawei.com --- drivers/edac/ghes_edac.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c index 863fbf3db29f..473aeec4b1da 100644 --- a/drivers/edac/ghes_edac.c +++ b/drivers/edac/ghes_edac.c @@ -440,12 +440,16 @@ int ghes_edac_register(struct ghes *ghes, struct device *dev) struct mem_ctl_info *mci; struct edac_mc_layer layers[1]; struct ghes_edac_dimm_fill dimm_fill; - int idx; + int idx = -1; - /* Check if safe to enable on this system */ - idx = acpi_match_platform_list(plat_list); - if (!force_load && idx < 0) - return -ENODEV; + if (IS_ENABLED(CONFIG_X86)) { + /* Check if safe to enable on this system */ + idx = acpi_match_platform_list(plat_list); + if (!force_load && idx < 0) + return -ENODEV; + } else { + idx = 0; + } /* * We have only one logical memory controller to which all DIMMs belong. -- 2.17.0.391.g1f1cddd558b5 -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.