From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH 17/27] dt-bindings: ap806: add the thermal node in the syscon file Date: Fri, 18 May 2018 11:56:09 +0200 Message-ID: <20180518115609.420de41d@xps13> References: <20180421151255.29929-1-miquel.raynal@bootlin.com> <20180421151255.29929-18-miquel.raynal@bootlin.com> <20180427210722.obyujepjvqc5hwcd@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180427210722.obyujepjvqc5hwcd@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rob Herring Cc: Mark Rutland , Andrew Lunn , Jason Cooper , Nadav Haklai , devicetree@vger.kernel.org, Antoine Tenart , Catalin Marinas , Gregory Clement , linux-pm@vger.kernel.org, Will Deacon , Maxime Chevallier , Eduardo Valentin , David Sniatkiwicz , Thomas Petazzoni , Zhang Rui , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth List-Id: linux-pm@vger.kernel.org SGkgUm9iLAoKVGhhbmtzIGZvciByZXZpZXdpbmcsIG9uZSBxdWVzdGlvbiBiZWxvdy4KCk9uIEZy aSwgMjcgQXByIDIwMTggMTY6MDc6MjIgLTA1MDAsIFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5lbC5v cmc+IHdyb3RlOgoKPiBPbiBTYXQsIEFwciAyMSwgMjAxOCBhdCAwNToxMjo0NVBNICswMjAwLCBN aXF1ZWwgUmF5bmFsIHdyb3RlOgo+ID4gRXhwbGFpbiB0aGUgdGhlcm1hbCBiaW5kaW5ncyBub3cg dGhhdCB0aGUgdGhlcm1hbCBJUCBpcyBkZXNjcmliZWQgYmVpbmcKPiA+IGluc2lkZSBvZiBhIHN5 c3RlbSBjb250cm9sbGVyLiBBZGQgYSByZWZlcmVuY2UgdG8gdGhlIHRoZXJtYWwtem9uZSBub2Rl Lgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJv b3RsaW4uY29tPgo+ID4gLS0tCj4gPiAgLi4uL2FybS9tYXJ2ZWxsL2FwODA2LXN5c3RlbS1jb250 cm9sbGVyLnR4dCAgICAgICAgfCA0MyArKysrKysrKysrKysrKysrKysrKysrCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWFydmVsbC9hcDgwNi1zeXN0ZW0tY29udHJv bGxlci50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvYXJtL21hcnZlbGwv YXA4MDYtc3lzdGVtLWNvbnRyb2xsZXIudHh0Cj4gPiBpbmRleCBhODU2ZWI5YTRlMDUuLmM5NWYz YWM1YzcyOCAxMDA2NDQKPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9hcm0vbWFydmVsbC9hcDgwNi1zeXN0ZW0tY29udHJvbGxlci50eHQKPiA+ICsrKyBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWFydmVsbC9hcDgwNi1zeXN0ZW0tY29u dHJvbGxlci50eHQKPiA+IEBAIC0xMSw2ICsxMSw5IEBAIEZvciB0aGUgdG9wIGxldmVsIG5vZGU6 Cj4gPiAgIC0gY29tcGF0aWJsZTogbXVzdCBiZTogInN5c2NvbiIsICJzaW1wbGUtbWZkIjsKPiA+ ICAgLSByZWc6IHJlZ2lzdGVyIGFyZWEgb2YgdGhlIEFQODA2IHN5c3RlbSBjb250cm9sbGVyCj4g PiAgCj4gPiArU1lTVEVNIENPTlRST0xMRVIgMAo+ID4gKz09PT09PT09PT09PT09PT09PT0KPiA+ ICsKPiA+ICBDbG9ja3M6Cj4gPiAgLS0tLS0tLQo+ID4gIAo+ID4gQEAgLTk4LDMgKzEwMSw0MyBA QCBhcF9zeXNjb246IHN5c3RlbS1jb250cm9sbGVyQDZmNDAwMCB7Cj4gPiAgCQlncGlvLXJhbmdl cyA9IDwmYXBfcGluY3RybCAwIDAgMTk+Owo+ID4gIAl9Owo+ID4gIH07Cj4gPiArCj4gPiArU1lT VEVNIENPTlRST0xMRVIgMQo+ID4gKz09PT09PT09PT09PT09PT09PT0KPiA+ICsKPiA+ICtUaGVy bWFsOgo+ID4gKy0tLS0tLS0tCj4gPiArCj4gPiArRm9yIGNvbW1vbiBiaW5kaW5nIHBhcnQgYW5k IHVzYWdlLCByZWZlciB0bwo+ID4gK0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy90 aGVybWFsL3RoZXJtYWwudHh0Cj4gPiArCj4gPiArVGhlIHRoZXJtYWwgSVAgY2FuIHByb2JlIHRo ZSB0ZW1wZXJhdHVyZSBhbGwgYXJvdW5kIHRoZSBwcm9jZXNzb3IuIEl0Cj4gPiArbWF5IGZlYXR1 cmUgc2V2ZXJhbCBjaGFubmVscywgZWFjaCBvZiB0aGVtIHdpcmVkIHRvIG9uZSBzZW5zb3IuCj4g PiArCj4gPiArSXQgaXMgcG9zc2libGUgdG8gc2V0dXAgYW4gb3ZlcmhlYXQgaW50ZXJydXB0IGJ5 IGdpdmluZyBhdCBsZWFzdCBvbmUKPiA+ICtjcml0aWNhbCBwb2ludCB0byBhbnkgc3Vibm9kZSBv ZiB0aGUgdGhlcm1hbC16b25lIG5vZGUuCj4gPiArCj4gPiArUmVxdWlyZWQgcHJvcGVydGllczoK PiA+ICstIGNvbXBhdGlibGU6ICJtYXJ2ZWxsLGFybWFkYS1hcDgwNi10aGVybWFsIgo+ID4gKwo+ ID4gK09wdGlvbmFsIHByb3BlcnRpZXM6Cj4gPiArLSBpbnRlcnJ1cHQtcGFyZW50L2ludGVycnVw dHM6IG92ZXJoZWF0IGludGVycnVwdCBoYW5kbGUuIFNob3VsZCBwb2ludCB0bwo+ID4gKyAgbGlu ZSAxOCBvZiB0aGUgU0VJIGlycWNoaXAuCj4gPiArICBTZWUgaW50ZXJydXB0LWNvbnRyb2xsZXIv aW50ZXJydXB0cy50eHQKPiA+ICstICN0aGVybWFsLXNlbnNvci1jZWxsczogc2hhbGwgYmUgPDE+ IHdoZW4gdGhlcm1hbC16b25lcyBzdWJub2RlcyByZWZlcgo+ID4gKyAgdG8gdGhpcyBJUCBhbmQg cmVwcmVzZW50cyB0aGUgY2hhbm5lbCBJRC4gVGhlcmUgaXMgb25lIHNlbnNvciBwZXIKPiA+ICsg IGNoYW5uZWwuIE8gcmVmZXJzIHRvIHRoZSB0aGVybWFsIElQIGludGVybmFsIGNoYW5uZWwsIHdo aWxlIHBvc2l0aXZlCj4gPiArICBJRHMgcmVmZXIgdG8gZWFjaCBDUFUuCj4gPiArCj4gPiArRXhh bXBsZToKPiA+ICthcF9zeXNjb24xOiBzeXN0ZW0tY29udHJvbGxlckA2ZjgwMDAgewo+ID4gKwlj b21wYXRpYmxlID0gInN5c2NvbiIsICJzaW1wbGUtbWZkIjsKPiA+ICsJcmVnID0gPDB4NmY4MDAw IDB4MTAwMD47Cj4gPiArCj4gPiArCWFwX3RoZXJtYWw6IGFwLXRoZXJtYWwgewo+ID4gKwkJY29t cGF0aWJsZSA9ICJtYXJ2ZWxsLGFybWFkYS1hcDgwNi10aGVybWFsIjsgIAo+IAo+IElzIHRoZXJl IGEgcmVnaXN0ZXIgcmFuZ2UgYXNzb2NpYXRlZCB3aXRoIHRoZSB0aGVybWFsIGZ1bmN0aW9ucz8K CkluZGVlZCB0aGVyZSBpcyBhIHNtYWxsIG9uZSAodGhyZWUgcmVnaXN0ZXJzKSBidXQgd2UgYWxz byBuZWVkIHRvIGFjY2Vzcwpzb21lIHJlZ2lzdGVycyBvdXQgb2YgdGhpcyBhcmVhIChzbyBjYWxs ZWQgdGhlICdERlgnIGFyZWEsIGluIHRoaXMKc3lzY29uLCB0byByb3V0ZSBjb3JyZWN0bHkgdGhl IGludGVycnVwdCkgYW5kIEkgZmVhciB3ZSdsbCBuZWVkIHRvCmFjY2VzcyBvdGhlcnMgaW4gdGhl IGZ1dHVyZS4gSSBjaG9vc2UgdG8gZGVjbGFyZSBhIHN5c2NvbiBiZWNhdXNlIHRoaXMKYXJlYSBt aXhlcyBhIGxvdCBvZiBtaXNjIHJlZ2lzdGVycy4KClNvIGRvIHlvdSB0aGluayBJIHNob3VsZCBk ZWNsYXJlIHRoZXNlIDMgcmVnaXN0ZXJzIGFyZWEgaW4gYSByZWcKcHJvcGVydHk/IE9yIGtlZXAg dGhlIHdheSBJIHJldHJpZXZlZCB0aGUgb2Zmc2V0cyBpbiB0aGUgc3lzY29uOgpkZWZpbmluZyBv ZmZzZXRzIGluIHRoZSBjb2RlPwoKPiAKPiA+ICsJCWludGVycnVwdC1wYXJlbnQgPSA8JnNlaT47 Cj4gPiArCQlpbnRlcnJ1cHRzID0gPDE4PjsKPiA+ICsJCSN0aGVybWFsLXNlbnNvci1jZWxscyA9 IDwxPjsKPiA+ICsJfTsKPiA+ICt9Owo+ID4gLS0gCj4gPiAyLjE0LjEKPiA+ICAgCgpUaGFua3Ms Ck1pcXXDqGwKCi0tIApNaXF1ZWwgUmF5bmFsLCBCb290bGluIChmb3JtZXJseSBGcmVlIEVsZWN0 cm9ucykKRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3Rs aW4uY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: miquel.raynal@bootlin.com (Miquel Raynal) Date: Fri, 18 May 2018 11:56:09 +0200 Subject: [PATCH 17/27] dt-bindings: ap806: add the thermal node in the syscon file In-Reply-To: <20180427210722.obyujepjvqc5hwcd@rob-hp-laptop> References: <20180421151255.29929-1-miquel.raynal@bootlin.com> <20180421151255.29929-18-miquel.raynal@bootlin.com> <20180427210722.obyujepjvqc5hwcd@rob-hp-laptop> Message-ID: <20180518115609.420de41d@xps13> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, Thanks for reviewing, one question below. On Fri, 27 Apr 2018 16:07:22 -0500, Rob Herring wrote: > On Sat, Apr 21, 2018 at 05:12:45PM +0200, Miquel Raynal wrote: > > Explain the thermal bindings now that the thermal IP is described being > > inside of a system controller. Add a reference to the thermal-zone node. > > > > Signed-off-by: Miquel Raynal > > --- > > .../arm/marvell/ap806-system-controller.txt | 43 ++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > > index a856eb9a4e05..c95f3ac5c728 100644 > > --- a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > > +++ b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > > @@ -11,6 +11,9 @@ For the top level node: > > - compatible: must be: "syscon", "simple-mfd"; > > - reg: register area of the AP806 system controller > > > > +SYSTEM CONTROLLER 0 > > +=================== > > + > > Clocks: > > ------- > > > > @@ -98,3 +101,43 @@ ap_syscon: system-controller at 6f4000 { > > gpio-ranges = <&ap_pinctrl 0 0 19>; > > }; > > }; > > + > > +SYSTEM CONTROLLER 1 > > +=================== > > + > > +Thermal: > > +-------- > > + > > +For common binding part and usage, refer to > > +Documentation/devicetree/bindings/thermal/thermal.txt > > + > > +The thermal IP can probe the temperature all around the processor. It > > +may feature several channels, each of them wired to one sensor. > > + > > +It is possible to setup an overheat interrupt by giving at least one > > +critical point to any subnode of the thermal-zone node. > > + > > +Required properties: > > +- compatible: "marvell,armada-ap806-thermal" > > + > > +Optional properties: > > +- interrupt-parent/interrupts: overheat interrupt handle. Should point to > > + line 18 of the SEI irqchip. > > + See interrupt-controller/interrupts.txt > > +- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer > > + to this IP and represents the channel ID. There is one sensor per > > + channel. O refers to the thermal IP internal channel, while positive > > + IDs refer to each CPU. > > + > > +Example: > > +ap_syscon1: system-controller at 6f8000 { > > + compatible = "syscon", "simple-mfd"; > > + reg = <0x6f8000 0x1000>; > > + > > + ap_thermal: ap-thermal { > > + compatible = "marvell,armada-ap806-thermal"; > > Is there a register range associated with the thermal functions? Indeed there is a small one (three registers) but we also need to access some registers out of this area (so called the 'DFX' area, in this syscon, to route correctly the interrupt) and I fear we'll need to access others in the future. I choose to declare a syscon because this area mixes a lot of misc registers. So do you think I should declare these 3 registers area in a reg property? Or keep the way I retrieved the offsets in the syscon: defining offsets in the code? > > > + interrupt-parent = <&sei>; > > + interrupts = <18>; > > + #thermal-sensor-cells = <1>; > > + }; > > +}; > > -- > > 2.14.1 > > Thanks, Miqu?l -- Miquel Raynal, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com