From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org
Subject: [1/4] USB: serial: ftdi_sio: fix IXON/IXOFF mixup
Date: Fri, 18 May 2018 16:53:11 +0200 [thread overview]
Message-ID: <20180518145311.GA3757@kroah.com> (raw)
On Fri, May 18, 2018 at 04:33:50PM +0200, Johan Hovold wrote:
> On Fri, May 18, 2018 at 03:53:54PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, May 18, 2018 at 03:25:47PM +0200, Johan Hovold wrote:
> > > Since forever this driver has had IXON and IXOFF mixed up, and has used
> > > the latter rather than the former to enable hardware-assisted software
> > > flow control on output.
>
> > Ugh, that's a huge sign that no one actually uses IXON/IXOFF anymore :(
>
> Could be that some applications set both IXON and IXOFF "just to be
> safe"; that appears to be the case with minicom at least.
>
> > Anyway, thanks for fixing this up, should also probably be backported to
> > the stable kernels.
>
> I considered that, but since its a change in behaviour I figured it was
> best that anyone affected hits this with a major (minor?) kernel version
> update (rather than a stable update). But I'll add a stable tag if you
> think it's warranted?
Fair enough. If anyone notices we can easily backport it later on if
needed.
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-05-18 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 14:53 Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-18 14:33 [1/4] USB: serial: ftdi_sio: fix IXON/IXOFF mixup Johan Hovold
2018-05-18 13:53 Greg Kroah-Hartman
2018-05-18 13:25 Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518145311.GA3757@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.