All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Mel Gorman <mgorman@suse.de>, Trond Myklebust <trondmy@hammerspace.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-nfs@vger.kernel.org
Subject: do we still need ->is_dirty_writeback
Date: Fri, 18 May 2018 19:08:12 +0200	[thread overview]
Message-ID: <20180518170812.GA5190@lst.de> (raw)

Hi Mel,

you added the is_dirty_writeback callback a couple years ago mostly
to work around the crazy ext3 writeback code, which is long gone now.
We still use buffer_check_dirty_writeback on the block device, but
without that ext3 case we really should not need it anymore.

That leaves NFS, where I don't understand why it doesn't simply
use PageWrite?

             reply	other threads:[~2018-05-18 17:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 17:08 Christoph Hellwig [this message]
2018-05-21  9:05 ` do we still need ->is_dirty_writeback Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180518170812.GA5190@lst.de \
    --to=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.