From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH 2/7] nvme-pci: simplify nvme_cqe_valid
Date: Fri, 18 May 2018 14:49:47 -0600 [thread overview]
Message-ID: <20180518204947.GC27795@localhost.localdomain> (raw)
In-Reply-To: <1526655155-4006-3-git-send-email-axboe@kernel.dk>
On Fri, May 18, 2018@08:52:30AM -0600, Jens Axboe wrote:
> +static inline bool nvme_cqe_pending(struct nvme_queue *nvmeq)
> {
> - return (le16_to_cpu(nvmeq->cqes[head].status) & 1) == phase;
> + return (le16_to_cpu(nvmeq->cqes[nvmeq->cq_head].status) & 1) ==
> + nvmeq->cq_phase;
> }
What happened to the byte-swap micro-optimization?
next prev parent reply other threads:[~2018-05-18 20:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 14:52 [PATCHSET v2 0/7] Improve nvme completion handling Jens Axboe
2018-05-18 14:52 ` [PATCH 1/7] nvme: mark the result argument to nvme_complete_async_event volatile Jens Axboe
2018-05-18 14:52 ` [PATCH 2/7] nvme-pci: simplify nvme_cqe_valid Jens Axboe
2018-05-18 20:49 ` Keith Busch [this message]
2018-05-18 20:48 ` Jens Axboe
2018-05-18 14:52 ` [PATCH 3/7] nvme-pci: remove cq check after submission Jens Axboe
2018-05-18 14:52 ` [PATCH 4/7] nvme-pci: move ->cq_vector == -1 check outside of ->q_lock Jens Axboe
2018-05-18 14:52 ` [PATCH 5/7] nvme-pci: handle completions outside of the queue lock Jens Axboe
2018-05-18 21:06 ` Keith Busch
2018-05-18 21:11 ` Jens Axboe
2018-05-18 21:22 ` Jens Axboe
2018-05-18 21:28 ` Keith Busch
2018-05-18 21:31 ` Jens Axboe
2018-05-18 21:48 ` Keith Busch
2018-05-18 22:46 ` Jens Axboe
2018-05-21 14:18 ` Jens Axboe
2018-05-21 14:23 ` Keith Busch
2018-05-21 14:33 ` Jens Axboe
2018-05-21 14:40 ` Keith Busch
2018-05-21 14:43 ` Keith Busch
2018-05-18 21:25 ` Keith Busch
2018-05-18 14:52 ` [PATCH 6/7] nvme-pci: split the nvme queue lock into submission and completion locks Jens Axboe
2018-05-18 14:52 ` [PATCH 7/7] nvme-pci: drop IRQ disabling on submission queue lock Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2018-05-17 16:31 RFC: handle completions outside the queue lock and split the " Christoph Hellwig
2018-05-17 16:31 ` [PATCH 2/7] nvme-pci: simplify nvme_cqe_valid Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518204947.GC27795@localhost.localdomain \
--to=keith.busch@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.