From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <konrad.wilk@oracle.com>
Received: from userp2130.oracle.com ([156.151.31.86])
	by Galois.linutronix.de with esmtps (TLS1.2:RSA_AES_256_CBC_SHA256:256)
	(Exim 4.80)
	(envelope-from <konrad.wilk@oracle.com>)
	id 1fJmYy-0000bB-Vv
	for speck@linutronix.de; Fri, 18 May 2018 23:05:22 +0200
Received: from pps.filterd (userp2130.oracle.com [127.0.0.1])
	by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w4IL1Vur034204
	for <speck@linutronix.de>; Fri, 18 May 2018 21:05:13 GMT
Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])
	by userp2130.oracle.com with ESMTP id 2hx29wpys9-1
	(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
	for <speck@linutronix.de>; Fri, 18 May 2018 21:05:12 +0000
Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72])
	by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w4IL5BXG021729
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
	for <speck@linutronix.de>; Fri, 18 May 2018 21:05:12 GMT
Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10])
	by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w4IL5BNk025890
	for <speck@linutronix.de>; Fri, 18 May 2018 21:05:11 GMT
Date: Fri, 18 May 2018 17:05:10 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [MODERATED] Re: [PATCH v17.1 2/2] [PATCH v17.1 2/2] SSB Fix #2
Message-ID: <20180518210510.GO23713@char.us.oracle.com>
References: <20180517031815.016936086@localhost.localdomain>
 <20180518132154.GB11225@kroah.com>
 <20180518182234.GB13846@char.us.oracle.com>
 <alpine.DEB.2.21.1805182155160.1599@nanos.tec.linutronix.de>
 <20180518203401.GK23713@char.us.oracle.com>
 <alpine.LFD.2.21.999.1805181339180.11543@i7.lan>
MIME-Version: 1.0
In-Reply-To: <alpine.LFD.2.21.999.1805181339180.11543@i7.lan>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
To: speck@linutronix.de
List-ID: <speck.linutronix.de>

On Fri, May 18, 2018 at 01:40:39PM -0700, speck for Linus Torvalds wrote:
> 
> 
> On Fri, 18 May 2018, speck for Konrad Rzeszutek Wilk wrote:
> > 
> > Yup. B/c there is no early callback installed yet and it ends up using 'cli'
> 
> Why isn't the default callback for cli (and restore-flags) just a no-op? 

The paravirt code hadn't yet run.
> 
> Interrupts had better not be enabled before the callbacks are done, so 
> they *should* default to not doing anything.
> 
>                Linus