From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH v7 2/2] Return bytes transferred for partial direct I/O
Date: Sat, 19 May 2018 21:29:01 -0400 [thread overview]
Message-ID: <20180520012901.GA5805@thunk.org> (raw)
In-Reply-To: <20180208185948.26827-2-rgoldwyn@suse.de>
On Thu, Feb 08, 2018 at 12:59:48PM -0600, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> In case direct I/O encounters an error midway, it returns the error.
> Instead it should be returning the number of bytes transferred so far.
>
> Test case for filesystems (with ENOSPC):
> 1. Create an almost full filesystem
> 2. Create a file, say /mnt/lastfile, until the filesystem is full.
> 3. Direct write() with count > sizeof /mnt/lastfile.
>
> Result: write() returns -ENOSPC. However, file content has data written
> in step 3.
>
> Added a sysctl entry: dio_short_writes which is on by default. This is
> to support applications which expect either and error or the bytes submitted
> as a return value for the write calls.
>
> This fixes fstest generic/472.
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Hi,
I was wondering if you could give an update regarding what's up with
this patch?
There doesn't seem to be any movement on this patch in a while, and so
I still have xfstests generic/472 suppressed in {kvm,gce}-xfstests.
Thanks,
- Ted
next prev parent reply other threads:[~2018-05-20 1:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 18:59 [PATCH v7 1/2] xfs: remove assert to check bytes returned Goldwyn Rodrigues
2018-02-08 18:59 ` [PATCH v7 2/2] Return bytes transferred for partial direct I/O Goldwyn Rodrigues
2018-03-08 0:53 ` Darrick J. Wong
2018-03-08 15:35 ` Goldwyn Rodrigues
2018-03-08 17:29 ` Darrick J. Wong
2018-05-20 1:29 ` Theodore Y. Ts'o [this message]
2018-05-20 13:54 ` Goldwyn Rodrigues
2018-02-09 4:52 ` [PATCH v7 1/2] xfs: remove assert to check bytes returned Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180520012901.GA5805@thunk.org \
--to=tytso@mit.edu \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.