From: Wolfram Sang <wsa@the-dreams.de>
To: Peter Rosin <peda@axentia.se>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: mux: demux-pinctrl: use proper parent device for demux adapter
Date: Sun, 20 May 2018 08:45:40 +0200 [thread overview]
Message-ID: <20180520064540.t54o7akrmx3g6cd6@ninjato> (raw)
In-Reply-To: <12bff5fc-dee4-e0bf-2dde-96201a8cd1fb@axentia.se>
On Sat, May 19, 2018 at 11:40:04PM +0200, Peter Rosin wrote:
> On 2018-04-30 13:55, Wolfram Sang wrote:
> > Due to a typo, the wrong parent device was assigned to the newly created
> > demuxing adapter device. It got connected to the demuxing platform
> > device but not to the selected parent I2C adapter device. Fix it to get
> > a proper parent-child relationship of the demuxed busses, needed also for
> > proper PM.
> >
>
> Should this one have a Fixes: tag? Should it go to current or next? Is
> a backport to stable good enough?
A Fixes tag is probably apropriate. I don't think it should go to
stable, though, because it will break a scheme a user might be using.
This can't be avoided for a kernel upgrade here, but IMO we shouldn't
enforce it for a stable update. Especially, given this is not a real
bug, but more something improper. For the same reason, I'd think -next
is good enough.
Thanks, will resend!
Wolfram
next prev parent reply other threads:[~2018-05-20 6:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 11:55 [PATCH 0/2] i2c: mux: demux-pinctrl: improve device relationships Wolfram Sang
2018-04-30 11:55 ` [PATCH 1/2] i2c: mux: demux-pinctrl: use proper parent device for demux adapter Wolfram Sang
2018-05-19 21:40 ` Peter Rosin
2018-05-20 6:45 ` Wolfram Sang [this message]
2018-05-20 7:07 ` Peter Rosin
2018-04-30 11:55 ` [PATCH 2/2] i2c: mux: demux-pinctrl: add symlinks to the demux device in sysfs Wolfram Sang
2018-05-19 21:40 ` Peter Rosin
2018-05-20 6:45 ` Wolfram Sang
2018-05-17 14:11 ` [PATCH 0/2] i2c: mux: demux-pinctrl: improve device relationships Wolfram Sang
2018-05-19 21:38 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180520064540.t54o7akrmx3g6cd6@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.