All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kai Krakow <kai@kaishome.de>
Cc: colyli@suse.de, axboe@kernel.dk, kent.overstreet@gmail.com,
	massimo.b@gmx.net, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] bcache: return 0 from bch_debug_init() if CONFIG_DEBUG_FS=n" failed to apply to 4.16-stable tree
Date: Sun, 20 May 2018 11:04:07 +0200	[thread overview]
Message-ID: <20180520090407.GA17965@kroah.com> (raw)
In-Reply-To: <CAC2ZOYu1fGm2vHyx_Pp_DVsTMUKeYGHO6W_0NrW=M+-Anwr-Qw@mail.gmail.com>

On Sun, May 20, 2018 at 10:59:32AM +0200, Kai Krakow wrote:
> Hey Greg!
> 
> The v1 version applied for me but it shows a compiler warning. I didn't try
> the newer version yet.
> 
> I could prepare a back-ported version.

Backported would be good.

Also, the code really is wrong even with this change.  No code path
should ever do anything different if debugfs is enabled or not, or based
on the return value of a debugfs call.  No need to check anything here
at all, the function should be:

void __init bch_debug_init(void)
{
	bcache_debug = debugfs_create_dir("bcache", NULL);
}

That's it, no checking, and all is fine and good.  Any result of a
debugfs call can always be fed back into another debugfs call with no
harm or errors happening.

thanks,

greg k-h

  parent reply	other threads:[~2018-05-20  9:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-20  7:49 FAILED: patch "[PATCH] bcache: return 0 from bch_debug_init() if CONFIG_DEBUG_FS=n" failed to apply to 4.16-stable tree gregkh
2018-05-20  9:01 ` Kai Krakow
     [not found] ` <CAC2ZOYu1fGm2vHyx_Pp_DVsTMUKeYGHO6W_0NrW=M+-Anwr-Qw@mail.gmail.com>
2018-05-20  9:04   ` Greg KH [this message]
2018-05-20  9:14     ` Kai Krakow
2018-05-20  9:38       ` Coly Li
2018-05-20  9:42         ` Kai Krakow
2018-05-20  9:38       ` Greg KH
2018-05-20  9:53 ` [PATCH] bcache: return 0 from bch_debug_init() if CONFIG_DEBUG_FS=n Kai Krakow
2018-05-20 12:52   ` Coly Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180520090407.GA17965@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=colyli@suse.de \
    --cc=kai@kaishome.de \
    --cc=kent.overstreet@gmail.com \
    --cc=massimo.b@gmx.net \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.