All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] ltrace: remove bogus comment in Config.in file
Date: Sun, 20 May 2018 19:25:20 +0200	[thread overview]
Message-ID: <20180520192520.15cf72bc@windsurf> (raw)
In-Reply-To: <20180519205502.23746-1-thomas.petazzoni@bootlin.com>

Hello,

On Sat, 19 May 2018 22:55:01 +0200, Thomas Petazzoni wrote:
> In commit dfaa18af00dfcff71a0159adaafb0880e58fa6a1 ("ltrace: disable
> on mips/mipsel"), ltrace was disabled on mips/mipsel due to build
> issues, and a comment was added in the Config.in file to explain that
> even though ltrace has mips/mipsel support, it isn't enabled because
> it doesn't build.
> 
> Then, in commit d23cce19c299e3010ba2dca84ab4ad35eff3cdbb ("ltrace:
> enable for mips/mipsel"), the build of ltrace on mips/mipsel was
> re-enabled, because it has been fixed upstream.
> 
> However, the comment in the Config.in comment was not removed in this
> commit. Due to this, we have a comment that says "we don't allow
> enabling ltrace on mips/mipsel" and the line right below precisely
> allows to enable ltrace on mips/mipsel.
> 
> Fix this inconsistency by removing the no longer valid comment.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/ltrace/Config.in | 4 ----
>  1 file changed, 4 deletions(-)

I've applied those two patches to master.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-05-20 17:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-19 20:55 [Buildroot] [PATCH 1/2] ltrace: remove bogus comment in Config.in file Thomas Petazzoni
2018-05-19 20:55 ` [Buildroot] [PATCH 2/2] ltrace: fix visibility of Config.in comment Thomas Petazzoni
2018-06-11 21:17   ` Peter Korsgaard
2018-05-20 17:25 ` Thomas Petazzoni [this message]
2018-06-11 21:17 ` [Buildroot] [PATCH 1/2] ltrace: remove bogus comment in Config.in file Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180520192520.15cf72bc@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.