All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libgit2: New package.
Date: Sun, 20 May 2018 22:27:31 +0200	[thread overview]
Message-ID: <20180520222731.6757154c@windsurf> (raw)
In-Reply-To: <20180214111351.4801-2-nicolas.cavallari@green-communications.fr>

Hello,

On Wed, 14 Feb 2018 12:13:51 +0100, Nicolas Cavallari wrote:
> Signed-off-by: Nicolas Cavallari <nicolas.cavallari@green-communications.fr>
> ---
>  DEVELOPERS                   |  3 +++
>  package/Config.in            |  1 +
>  package/libgit2/Config.in    |  9 +++++++++
>  package/libgit2/libgit2.hash |  3 +++
>  package/libgit2/libgit2.mk   | 25 +++++++++++++++++++++++++
>  5 files changed, 41 insertions(+)
>  create mode 100644 package/libgit2/Config.in
>  create mode 100644 package/libgit2/libgit2.hash
>  create mode 100644 package/libgit2/libgit2.mk

So, I've applied to next, but I had to change quite a few things that
were not really correct:

    [Thomas:
     - Do not select BR2_PACKAGE_ZLIB, because zlib is an optional
       dependency.
     - Handle optional dependencies in a more usual way in libgit2.mk:
       group the addition in _DEPENDENCIES and in _CONF_OPTS for a given
       library together.
     - libgit2 can optionally use libssh2, not libssh.
     - Add the optional dependency on zlib.
     - Always pass USE_ICONV=ON, the detection works perfectly fine, with
       both a C library providing iconv support built-in, and with
       libiconv. If neither provides iconv, it gets disabled automatically
       as expected.
     - Add libiconv as an optional dependency.]

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-20 20:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 11:13 [Buildroot] Adding package libgit2 Nicolas Cavallari
2018-02-14 11:13 ` [Buildroot] [PATCH 1/1] libgit2: New package Nicolas Cavallari
2018-05-20 20:27   ` Thomas Petazzoni [this message]
2018-05-22 17:19     ` Nicolas Cavallari
2018-05-22 19:14       ` Thomas Petazzoni
2018-02-14 15:06 ` [Buildroot] Adding package libgit2 Thomas Petazzoni
2018-02-14 15:30   ` Nicolas Cavallari
2018-02-14 15:36     ` Thomas Petazzoni
2018-02-25 21:27       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180520222731.6757154c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.