From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] uwsgi: new package
Date: Sun, 20 May 2018 23:46:27 +0200 [thread overview]
Message-ID: <20180520234627.5484405e@windsurf> (raw)
In-Reply-To: <20180202140601.21285-1-aduskett@gmail.com>
Hello,
On Fri, 2 Feb 2018 09:05:59 -0500, Adam Duskett wrote:
> Uwsgi is a web server gateway interface written in python that is
> meant to be flexible and plugin oriented.
>
> To get it to cross compile, 2 small patches had to be created:
>
> The first fixes the build system attempting to link against /usr/lib
> instead of sysconfig.PREFIX.
>
> The second adds a way to specify a location for xml2-config, as the
> build-system currently just blindly calls out xml2-config which
> can be on the host machine.
>
> Signed-off-by: Adam Duskett <aduskett@gmail.com>
I am sorry, but this is again not up to the level of quality that I
would expect from an experienced contributor like you.
(1) It fails to build with uClibc, first because it includes
<execinfo.h> when __GLIBC__ is defined. I've fixed that.
(2) It still fails to build with uClibc, because a workaround for a
glibc 2.2.3 bug gets enabled with uClibc and doesn't build. I've
fixed that.
(3) You make util-linux, pcre, jansson and libxml2 mandatory
dependencies, but they are not. You can customize
buildconf/base.ini to disable these. I was able to do a uwsgi
build with none of those dependencies enabled.
(4) I've done a build with python-setuptools on the target, and uwsgi
works just fine.
So this clearly needs to be reworked. Could you have another look at
this package, and make an improved submission ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-05-20 21:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 14:05 [Buildroot] [PATCH v2 1/3] uwsgi: new package Adam Duskett
2018-02-02 14:06 ` [Buildroot] [PATCH v2 2/3] php: add SAPI API librari option Adam Duskett
2018-02-02 14:06 ` [Buildroot] [PATCH v2 3/3] uwsgi: add plugin support Adam Duskett
2018-05-20 21:46 ` Thomas Petazzoni [this message]
2018-05-20 21:50 ` [Buildroot] [PATCH v2 1/3] uwsgi: new package Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2019-11-23 20:20 [Buildroot] [PATCH v2 0/3] " aduskett at gmail.com
2019-11-23 20:20 ` [Buildroot] [PATCH v2 1/3] " aduskett at gmail.com
2020-02-04 12:54 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180520234627.5484405e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.