From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH v11 52/63] dax: dax_insert_mapping_entry always succeeds Date: Sun, 20 May 2018 22:33:15 -0600 Message-ID: <20180521043315.GB27043@linux.intel.com> References: <20180414141316.7167-1-willy@infradead.org> <20180414141316.7167-53-willy@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fKcVj-0000JG-LS for linux-f2fs-devel@lists.sourceforge.net; Mon, 21 May 2018 04:33:27 +0000 Received: from mga12.intel.com ([192.55.52.136]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1fKcVf-00BlvF-A8 for linux-f2fs-devel@lists.sourceforge.net; Mon, 21 May 2018 04:33:27 +0000 Content-Disposition: inline In-Reply-To: <20180414141316.7167-53-willy@infradead.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Matthew Wilcox Cc: linux-nilfs@vger.kernel.org, Jan Kara , Jeff Layton , Matthew Wilcox , James Simmons , Jaegeuk Kim , Andreas Dilger , Nicholas Piggin , linux-f2fs-devel@lists.sourceforge.net, Oleg Drokin , linux-mm@kvack.org, Ryusuke Konishi , linux-fsdevel@vger.kernel.org, Lukas Czerner , Ross Zwisler , Christoph Hellwig , Goldwyn Rodrigues , Mike Kravetz On Sat, Apr 14, 2018 at 07:13:05AM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > It does not return an error, so we don't need to check the return value > for IS_ERR(). > > Signed-off-by: Matthew Wilcox Yep, this looks correct to me. You can add: Reviewed-by: Ross Zwisler ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 20 May 2018 22:33:15 -0600 From: Ross Zwisler To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Matthew Wilcox , Jan Kara , Jeff Layton , Lukas Czerner , Ross Zwisler , Christoph Hellwig , Goldwyn Rodrigues , Nicholas Piggin , Ryusuke Konishi , linux-nilfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Oleg Drokin , Andreas Dilger , James Simmons , Mike Kravetz Subject: Re: [PATCH v11 52/63] dax: dax_insert_mapping_entry always succeeds Message-ID: <20180521043315.GB27043@linux.intel.com> References: <20180414141316.7167-1-willy@infradead.org> <20180414141316.7167-53-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180414141316.7167-53-willy@infradead.org> Sender: owner-linux-mm@kvack.org List-ID: On Sat, Apr 14, 2018 at 07:13:05AM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > It does not return an error, so we don't need to check the return value > for IS_ERR(). > > Signed-off-by: Matthew Wilcox Yep, this looks correct to me. You can add: Reviewed-by: Ross Zwisler