From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH v4] batman-adv: Snoop DHCPACKs for DAT
Date: Mon, 21 May 2018 12:49:23 +0200 [thread overview]
Message-ID: <20180521104923.GI7162@otheros> (raw)
In-Reply-To: <1566281.z125QuZFdt@sven-edge>
On Fri, May 18, 2018 at 11:46:56PM +0200, Sven Eckelmann wrote:
> Please correct me but it doesn't look like these things have anything to do
> with the batman-adv packet format. And userspace should also not use the
> bootp_pkt/batadv_dhcp_packet definition from batman-adv.
Good point. I could move those to distributed-arp-table.c to avoid
userspace from using it.
> And what about the basically duplicated bootp_pkt definition in net/ipv4/
> ipconfig.c?
Would it make sense to first add it to distributed-arp-table.c and
then later I'd make a second patch directly for netdev@ to unify those?
Alternatively, if I'd get a partial ACK for the DHCP snooping approach
in general here, I could do it the other way round, of course.
Regards, Linus
next prev parent reply other threads:[~2018-05-21 10:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 15:59 [B.A.T.M.A.N.] [PATCH v4] batman-adv: Snoop DHCPACKs for DAT Linus Lüssing
2018-05-18 21:46 ` Sven Eckelmann
2018-05-21 10:49 ` Linus Lüssing [this message]
2018-05-21 14:32 ` Sven Eckelmann
2018-05-18 22:08 ` Sven Eckelmann
2018-05-21 11:04 ` Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180521104923.GI7162@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.