From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/fourcc: add a 10bits fully packed variant of NV12 Date: Mon, 21 May 2018 17:49:48 +0300 Message-ID: <20180521144948.GF23723@intel.com> References: <20180520171705.29690-1-ayaka@soulik.info> <20180520171705.29690-2-ayaka@soulik.info> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180520171705.29690-2-ayaka@soulik.info> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Randy Li Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, nicolas.dufresne@collabora.com, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gTW9uLCBNYXkgMjEsIDIwMTggYXQgMDE6MTc6MDRBTSArMDgwMCwgUmFuZHkgTGkgd3JvdGU6 Cj4gVGhpcyBwaXhlbCBmb3JtYXQgaXMgYSBmdWxseSBwYWNrZWQgYW5kIDEwYml0cyB2YXJpYW50 IG9mIE5WMTIuCj4gQSBsdW1hIHBpeGVsIHdvdWxkIHRha2UgMTBiaXRzIGluIG1lbW9yeSwgd2l0 aG91dCBhbnkKPiBmaWxsZWQgYml0cyBiZXR3ZWVuIHBpeGVscyBpbiBhIHN0cmlkZS4gVGhlIGNv bG9yIGdhbXV0Cj4gZm9sbG93cyB0aGUgQlQuMjAyMCBzdGFuZGFyZC4KPiAKPiBTaWduZWQtb2Zm LWJ5OiBSYW5keSBMaSA8YXlha2FAc291bGlrLmluZm8+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9kcm1fZm91cmNjLmMgIHwgMSArCj4gIGluY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oIHwg MyArKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm91 cmNjLmMKPiBpbmRleCA1Y2E2Mzk1Y2Q0ZDMuLjFmNDM5NjdjNDAxMyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9m b3VyY2MuYwo+IEBAIC0xNzMsNiArMTczLDcgQEAgY29uc3Qgc3RydWN0IGRybV9mb3JtYXRfaW5m byAqX19kcm1fZm9ybWF0X2luZm8odTMyIGZvcm1hdCkKPiAgCQl7IC5mb3JtYXQgPSBEUk1fRk9S TUFUX1VZVlksCQkuZGVwdGggPSAwLCAgLm51bV9wbGFuZXMgPSAxLCAuY3BwID0geyAyLCAwLCAw IH0sIC5oc3ViID0gMiwgLnZzdWIgPSAxIH0sCj4gIAkJeyAuZm9ybWF0ID0gRFJNX0ZPUk1BVF9W WVVZLAkJLmRlcHRoID0gMCwgIC5udW1fcGxhbmVzID0gMSwgLmNwcCA9IHsgMiwgMCwgMCB9LCAu aHN1YiA9IDIsIC52c3ViID0gMSB9LAo+ICAJCXsgLmZvcm1hdCA9IERSTV9GT1JNQVRfQVlVViwJ CS5kZXB0aCA9IDAsICAubnVtX3BsYW5lcyA9IDEsIC5jcHAgPSB7IDQsIDAsIDAgfSwgLmhzdWIg PSAxLCAudnN1YiA9IDEsIC5oYXNfYWxwaGEgPSB0cnVlIH0sCj4gKwkJeyAuZm9ybWF0ID0gRFJN X0ZPUk1BVF9OVjEyXzEwTEU0MCwJLmRlcHRoID0gMCwgIC5udW1fcGxhbmVzID0gMiwgLmNwcCA9 IHsgMSwgMiwgMCB9LCAuaHN1YiA9IDIsIC52c3ViID0gMiB9LAo+ICAJfTsKPiAgCj4gIAl1bnNp Z25lZCBpbnQgaTsKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmgg Yi9pbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2MuaAo+IGluZGV4IGUwNDYxM2QzMGExMy4uOGVh YmYwMWU5NjZmIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4g KysrIGIvaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmgKPiBAQCAtMTQwLDYgKzE0MCw5IEBA IGV4dGVybiAiQyIgewo+ICAjZGVmaW5lIERSTV9GT1JNQVRfTlY2MQkJZm91cmNjX2NvZGUoJ04n LCAnVicsICc2JywgJzEnKSAvKiAyeDEgc3Vic2FtcGxlZCBDYjpDciBwbGFuZSAqLwo+ICAjZGVm aW5lIERSTV9GT1JNQVRfTlYyNAkJZm91cmNjX2NvZGUoJ04nLCAnVicsICcyJywgJzQnKSAvKiBu b24tc3Vic2FtcGxlZCBDcjpDYiBwbGFuZSAqLwo+ICAjZGVmaW5lIERSTV9GT1JNQVRfTlY0MgkJ Zm91cmNjX2NvZGUoJ04nLCAnVicsICc0JywgJzInKSAvKiBub24tc3Vic2FtcGxlZCBDYjpDciBw bGFuZSAqLwo+ICsvKiBBIGZ1bGx5IHBhY2tlZCB2YXJpYW50IG9mIE5WMTJfMTBMRTMyICovCgpX aGF0IGRvZXMgImZ1bGx5IHBhY2tlZCIgbWVhbj8gTlYxMl8xMExFMzIgZG9lc24ndCBldmVuIGV4 aXN0IHNvCnJlZmVycmluZyB0byBpdCBtYWtlcyBubyBzZW5zZS4KClBsZWFzZSB0cnkgdG8gcHJv dmlkZSBhbiB1bmFtYmlndW91cyBkZXNjcmlwdGlvbiBvZiBuZXcgZm9ybWF0cyBsaWtlIHdlCmhh dmUgZm9yIGV2ZXJ5dGhpbmcgZWxzZS4KCj4gKyNkZWZpbmUgRFJNX0ZPUk1BVF9OVjEyXzEwTEU0 MAlmb3VyY2NfY29kZSgnUicsICdLJywgJzInLCAnMCcpIC8qIDJ4MiBzdWJzYW1wbGVkIENyOkNi IHBsYW5lICovCj4gKwo+ICAKPiAgLyoKPiAgICogMyBwbGFuZSBZQ2JDcgo+IC0tIAo+IDIuMTQu Mwo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g ZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: ville.syrjala@linux.intel.com (Ville =?iso-8859-1?Q?Syrj=E4l=E4?=) Date: Mon, 21 May 2018 17:49:48 +0300 Subject: [PATCH 1/2] drm/fourcc: add a 10bits fully packed variant of NV12 In-Reply-To: <20180520171705.29690-2-ayaka@soulik.info> References: <20180520171705.29690-1-ayaka@soulik.info> <20180520171705.29690-2-ayaka@soulik.info> Message-ID: <20180521144948.GF23723@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, May 21, 2018 at 01:17:04AM +0800, Randy Li wrote: > This pixel format is a fully packed and 10bits variant of NV12. > A luma pixel would take 10bits in memory, without any > filled bits between pixels in a stride. The color gamut > follows the BT.2020 standard. > > Signed-off-by: Randy Li > --- > drivers/gpu/drm/drm_fourcc.c | 1 + > include/uapi/drm/drm_fourcc.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 5ca6395cd4d3..1f43967c4013 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -173,6 +173,7 @@ const struct drm_format_info *__drm_format_info(u32 format) > { .format = DRM_FORMAT_UYVY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_VYUY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_AYUV, .depth = 0, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true }, > + { .format = DRM_FORMAT_NV12_10LE40, .depth = 0, .num_planes = 2, .cpp = { 1, 2, 0 }, .hsub = 2, .vsub = 2 }, > }; > > unsigned int i; > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index e04613d30a13..8eabf01e966f 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -140,6 +140,9 @@ extern "C" { > #define DRM_FORMAT_NV61 fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */ > #define DRM_FORMAT_NV24 fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */ > #define DRM_FORMAT_NV42 fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */ > +/* A fully packed variant of NV12_10LE32 */ What does "fully packed" mean? NV12_10LE32 doesn't even exist so referring to it makes no sense. Please try to provide an unambiguous description of new formats like we have for everything else. > +#define DRM_FORMAT_NV12_10LE40 fourcc_code('R', 'K', '2', '0') /* 2x2 subsampled Cr:Cb plane */ > + > > /* > * 3 plane YCbCr > -- > 2.14.3 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrj?l? Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752820AbeEUOt6 (ORCPT ); Mon, 21 May 2018 10:49:58 -0400 Received: from mga06.intel.com ([134.134.136.31]:43914 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbeEUOtw (ORCPT ); Mon, 21 May 2018 10:49:52 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,426,1520924400"; d="scan'208";a="48503615" Date: Mon, 21 May 2018 17:49:48 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Randy Li Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, nicolas.dufresne@collabora.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] drm/fourcc: add a 10bits fully packed variant of NV12 Message-ID: <20180521144948.GF23723@intel.com> References: <20180520171705.29690-1-ayaka@soulik.info> <20180520171705.29690-2-ayaka@soulik.info> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180520171705.29690-2-ayaka@soulik.info> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 21, 2018 at 01:17:04AM +0800, Randy Li wrote: > This pixel format is a fully packed and 10bits variant of NV12. > A luma pixel would take 10bits in memory, without any > filled bits between pixels in a stride. The color gamut > follows the BT.2020 standard. > > Signed-off-by: Randy Li > --- > drivers/gpu/drm/drm_fourcc.c | 1 + > include/uapi/drm/drm_fourcc.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 5ca6395cd4d3..1f43967c4013 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -173,6 +173,7 @@ const struct drm_format_info *__drm_format_info(u32 format) > { .format = DRM_FORMAT_UYVY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_VYUY, .depth = 0, .num_planes = 1, .cpp = { 2, 0, 0 }, .hsub = 2, .vsub = 1 }, > { .format = DRM_FORMAT_AYUV, .depth = 0, .num_planes = 1, .cpp = { 4, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true }, > + { .format = DRM_FORMAT_NV12_10LE40, .depth = 0, .num_planes = 2, .cpp = { 1, 2, 0 }, .hsub = 2, .vsub = 2 }, > }; > > unsigned int i; > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index e04613d30a13..8eabf01e966f 100644 > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h > @@ -140,6 +140,9 @@ extern "C" { > #define DRM_FORMAT_NV61 fourcc_code('N', 'V', '6', '1') /* 2x1 subsampled Cb:Cr plane */ > #define DRM_FORMAT_NV24 fourcc_code('N', 'V', '2', '4') /* non-subsampled Cr:Cb plane */ > #define DRM_FORMAT_NV42 fourcc_code('N', 'V', '4', '2') /* non-subsampled Cb:Cr plane */ > +/* A fully packed variant of NV12_10LE32 */ What does "fully packed" mean? NV12_10LE32 doesn't even exist so referring to it makes no sense. Please try to provide an unambiguous description of new formats like we have for everything else. > +#define DRM_FORMAT_NV12_10LE40 fourcc_code('R', 'K', '2', '0') /* 2x2 subsampled Cr:Cb plane */ > + > > /* > * 3 plane YCbCr > -- > 2.14.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel