All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Oleksij Rempel <linux@rempel-privat.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 06/12] common.h: fix IOMEM() for MIPS64
Date: Mon, 21 May 2018 18:01:51 +0200	[thread overview]
Message-ID: <20180521160151.GA23637@ravnborg.org> (raw)
In-Reply-To: <3b52a9f7-7e66-ecc6-7812-f7384b26e90d@rempel-privat.de>

On Mon, May 21, 2018 at 05:26:25PM +0200, Oleksij Rempel wrote:
> Am 21.05.2018 um 17:04 schrieb Sam Ravnborg:
> > On Mon, May 21, 2018 at 02:54:32PM +0300, Peter Mamonov wrote:
> >> Signed-off-by: Peter Mamonov <pmamonov@gmail.com>
> >> ---
> >>  include/common.h | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/include/common.h b/include/common.h
> >> index 60e5005b8..4b3bcae40 100644
> >> --- a/include/common.h
> >> +++ b/include/common.h
> >> @@ -142,7 +142,11 @@ void barebox_set_hostname_no_overwrite(const char *);
> >>  #if defined(CONFIG_MIPS)
> >>  #include <asm/addrspace.h>
> >>  
> >> +#ifdef CONFIG_64BIT
> >> +#define IOMEM(addr)	((void __force __iomem *)PHYS_TO_XKSEG_UNCACHED(addr))
> >> +#else
> >>  #define IOMEM(addr)	((void __force __iomem *)CKSEG1ADDR(addr))
> >> +#endif
> >>  #else
> >>  #define IOMEM(addr)	((void __force __iomem *)(addr))
> >>  #endif
> > 
> > Another way to handle this would be to move the definition of IOMEM to asm/common.h
> > and then in this file define IOMEM only if not already defined.
> > 
> > Then we could avoid this MIPS specific stuff in the middle of a common file.
> 
> I would prefer
> arch/mips/include/asm/io.h
Agreed, much better place.

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-05-21 16:02 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 11:54 [PATCH v2 00/12] various fixes for MIPS64 Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 01/12] resource: fix iomem root resource for 64 bit Peter Mamonov
2018-05-21 18:44   ` Andrey Smirnov
2018-05-21 11:54 ` [PATCH v2 02/12] fs: fix memory access for 64bit MIPS Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 03/12] mtd: cfi-flash: fix write_buff() for 64BIT Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 04/12] i2c/muxes/i2c-mux-pca954x: fix private data retrieval for 64bit mode Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 05/12] MIPS: import 64-bit address conversion macros Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 06/12] common.h: fix IOMEM() for MIPS64 Peter Mamonov
2018-05-21 15:04   ` Sam Ravnborg
2018-05-21 15:26     ` Oleksij Rempel
2018-05-21 16:01       ` Sam Ravnborg [this message]
2018-05-22 15:00         ` Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 07/12] mips: fix copy_to_link_location for 64 bit mode Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 08/12] MIPS: use CKSEG1 instead of KSEG1 Peter Mamonov
2018-05-21 15:08   ` Sam Ravnborg
2018-05-21 18:17     ` Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 09/12] mips: fix warnings from CPHYSADDR() macro Peter Mamonov
2018-05-21 15:11   ` Sam Ravnborg
2018-05-22 15:05     ` Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 10/12] mips: add PHYS_ADDR_T_64BIT option Peter Mamonov
2018-05-22  6:59   ` Sascha Hauer
2018-05-21 11:54 ` [PATCH v2 11/12] mips: 64BIT selects PHYS_ADDR_T_64BIT Peter Mamonov
2018-05-21 11:54 ` [PATCH v2 12/12] fixup! MIPS: import optimized string functions from Linux Peter Mamonov
2018-05-21 15:50   ` Oleksij Rempel
2018-05-22 14:58     ` Peter Mamonov
2018-05-21 18:39 ` [PATCH v2 00/12] various fixes for MIPS64 Andrey Smirnov
2018-05-21 21:07   ` Peter Mamonov
2018-05-22  7:11 ` Sascha Hauer
2018-05-22  8:17   ` Peter Mamonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180521160151.GA23637@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=linux@rempel-privat.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.