From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZqoC3aSKDrqiUrMqsjdLcQJHLdBTheK4irZefnmwTxqtsVznLknkpOin50pE4gQzBBI3auL ARC-Seal: i=1; a=rsa-sha256; t=1526937565; cv=none; d=google.com; s=arc-20160816; b=gLsE71AZjeyTFK/GkBRzEsIcIhVwazvrKqskOqyGl5A/t39s2WLGEovYMtHR9umcJp 1a16G6bLeYsgOMqGhvUR38FHFR/2qdAM+QZgAhfoePaU4lT2w7lS8BEpsH6eWnfCEM53 wohbQUL3ZJvHPrq26lFFlbsT67n+ufIn6k3q1BG2rkkV5fk3jg7ExbjbiOZ++jgfZdrs h8CvzUFkFYgUM+OE0xHa3Eh5m0jixgEexyIxw38J7ANPOShMKdm/ZxWxCWFyYHb7P2oZ yipOe8woNGJg674UwXPC8fOVA7tMvqbEi/QYlAD6chA6izkNLQpreHWmATTxP72/7rnW bA/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=u/4kjz40eYrEFsF+6JS7NBn//QAAHIbEFat0uO0Bnrs=; b=hT2g5tk6RDHwc6lbCsEP7I0V9HiUtbrJzN5+BuRhyGK+roj0T34cW4qPYl9igGRJia rOM+SCevoQ4FRz704dwXaguDQGV74yvlNBKRYfkdDALzubVAGVbB4K7+iitzE5/8PR0b tE/czT6VKZIsTL0jaUjQqQSVCTOfmIQLEtcbRJBHboGHWfMpQZ06Zu8wFohfOzQrB+nJ T316TCRI1FygYl9tPgBMOCyyo/gl/N7GBWLrO5TJHWg6VgkIIt48jM/rHMrpiYPFum7I 2jIFgJKiI/qWlITpBQdSkSEREkgOdYe6lXrK+NmKbz+cWgWwjacGG8SepB1cM5o2RyA8 XxmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CNYIwULd; spf=pass (google.com: domain of srs0=nia/=ii=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=nia/=II=linuxfoundation.org=gregkh@kernel.org Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CNYIwULd; spf=pass (google.com: domain of srs0=nia/=ii=linuxfoundation.org=gregkh@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=SRS0=nia/=II=linuxfoundation.org=gregkh@kernel.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Filipe Manana , David Sterba Subject: [PATCH 4.14 41/95] Btrfs: fix xattr loss after power failure Date: Mon, 21 May 2018 23:11:31 +0200 Message-Id: <20180521210456.394614996@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180521210447.219380974@linuxfoundation.org> References: <20180521210447.219380974@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1601109807672624155?= X-GMAIL-MSGID: =?utf-8?q?1601110084514189182?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Filipe Manana commit 9a8fca62aacc1599fea8e813d01e1955513e4fad upstream. If a file has xattrs, we fsync it, to ensure we clear the flags BTRFS_INODE_NEEDS_FULL_SYNC and BTRFS_INODE_COPY_EVERYTHING from its inode, the current transaction commits and then we fsync it (without either of those bits being set in its inode), we end up not logging all its xattrs. This results in deleting all xattrs when replying the log after a power failure. Trivial reproducer $ mkfs.btrfs -f /dev/sdb $ mount /dev/sdb /mnt $ touch /mnt/foobar $ setfattr -n user.xa -v qwerty /mnt/foobar $ xfs_io -c "fsync" /mnt/foobar $ sync $ xfs_io -c "pwrite -S 0xab 0 64K" /mnt/foobar $ xfs_io -c "fsync" /mnt/foobar $ mount /dev/sdb /mnt $ getfattr --absolute-names --dump /mnt/foobar $ So fix this by making sure all xattrs are logged if we log a file's inode item and neither the flags BTRFS_INODE_NEEDS_FULL_SYNC nor BTRFS_INODE_COPY_EVERYTHING were set in the inode. Fixes: 36283bf777d9 ("Btrfs: fix fsync xattr loss in the fast fsync path") Cc: # 4.2+ Signed-off-by: Filipe Manana Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/tree-log.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -4669,6 +4669,7 @@ static int btrfs_log_inode(struct btrfs_ struct extent_map_tree *em_tree = &inode->extent_tree; u64 logged_isize = 0; bool need_log_inode_item = true; + bool xattrs_logged = false; path = btrfs_alloc_path(); if (!path) @@ -4971,6 +4972,7 @@ next_key: err = btrfs_log_all_xattrs(trans, root, inode, path, dst_path); if (err) goto out_unlock; + xattrs_logged = true; if (max_key.type >= BTRFS_EXTENT_DATA_KEY && !fast_search) { btrfs_release_path(path); btrfs_release_path(dst_path); @@ -4983,6 +4985,11 @@ log_extents: btrfs_release_path(dst_path); if (need_log_inode_item) { err = log_inode_item(trans, log, dst_path, inode); + if (!err && !xattrs_logged) { + err = btrfs_log_all_xattrs(trans, root, inode, path, + dst_path); + btrfs_release_path(path); + } if (err) goto out_unlock; }