From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: set_fs(KERNEL_DS) vs iovec
Date: Tue, 22 May 2018 03:20:00 -0700 [thread overview]
Message-ID: <20180522102000.GA20067@infradead.org> (raw)
In-Reply-To: <8c7ac8af210606f2e4be4bfbb0b2506be53b60e3.camel@kernel.crashing.org>
On Tue, May 22, 2018 at 03:08:35PM +1000, Benjamin Herrenschmidt wrote:
> Hence my question: Is is still acceptable these days to use
> set_fs(KERNEL_DS) for simple cases like this ?
Not at all.
> Or is it really
> deprecated and all new users should use the iovec's ?
Yes, please use iov_iter. It should actually make your code simpler,
too.
next prev parent reply other threads:[~2018-05-22 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 5:08 set_fs(KERNEL_DS) vs iovec Benjamin Herrenschmidt
2018-05-22 10:20 ` Christoph Hellwig [this message]
2018-05-22 12:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522102000.GA20067@infradead.org \
--to=hch@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.