All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: Unify kernel fault reporting
Date: Tue, 22 May 2018 18:17:44 +0100	[thread overview]
Message-ID: <20180522171743.GI26955@arm.com> (raw)
In-Reply-To: <20180521131451.41040-3-mark.rutland@arm.com>

On Mon, May 21, 2018 at 02:14:51PM +0100, Mark Rutland wrote:
> In do_page_fault(), we handle some kernel faults early, and simply
> die() with a message. For faults handled later, we dump the faulting
> address, decode the ESR, walk the page tables, and perform a number of
> steps to ensure that this data is reported.
> 
> Let's unify the handling of fatal kernel faults with a new
> die_kernel_fault() helper, handling all of these details. This is
> largely the same as the existing logic in __do_kernel_fault(), except
> that addresses are consistently padded to 16 hex characters, as would be
> expected for a 64-bit address.
> 
> The messages currently logged in do_page_fault are adjusted to fit into
> the die_kernel_fault() message template.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> ---
>  arch/arm64/mm/fault.c | 37 +++++++++++++++++++++++--------------
>  1 file changed, 23 insertions(+), 14 deletions(-)

Acked-by: Will Deacon <will.deacon@arm.com>

Will

  reply	other threads:[~2018-05-22 17:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 13:14 [PATCH 0/2] arm64: fatal kernel fault reporting improvements Mark Rutland
2018-05-21 13:14 ` [PATCH 1/2] arm64: make is_permission_fault() name clearer Mark Rutland
2018-05-22 17:06   ` Will Deacon
2018-05-21 13:14 ` [PATCH 2/2] arm64: Unify kernel fault reporting Mark Rutland
2018-05-22 17:17   ` Will Deacon [this message]
2018-05-23 10:47 ` [PATCH 0/2] arm64: fatal kernel fault reporting improvements Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180522171743.GI26955@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.