All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Vlad Buslov <vladbu@mellanox.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: sched: don't disable bh when accessing action idr
Date: Wed, 23 May 2018 09:32:39 +0200	[thread overview]
Message-ID: <20180523073239.GC3155@nanopsycho> (raw)
In-Reply-To: <1526932984-11544-1-git-send-email-vladbu@mellanox.com>

Mon, May 21, 2018 at 10:03:04PM CEST, vladbu@mellanox.com wrote:
>Initial net_device implementation used ingress_lock spinlock to synchronize
>ingress path of device. This lock was used in both process and bh context.
>In some code paths action map lock was obtained while holding ingress_lock.
>Commit e1e992e52faa ("[NET_SCHED] protect action config/dump from irqs")
>modified actions to always disable bh, while using action map lock, in
>order to prevent deadlock on ingress_lock in softirq. This lock was removed
>from net_device, so disabling bh, while accessing action map, is no longer
>necessary.
>
>Replace all action idr spinlock usage with regular calls that do not
>disable bh.
>
>Signed-off-by: Vlad Buslov <vladbu@mellanox.com>

Please add my tag to v3, with the description changes requested by Cong.
Acked-by: Jiri Pirko <jiri@mellanox.com>

Thanks!

  parent reply	other threads:[~2018-05-23  7:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 15:45 [PATCH] net: sched: don't disable bh when accessing action idr Vlad Buslov
2018-05-19  2:59 ` Cong Wang
2018-05-19 10:12   ` Vlad Buslov
2018-05-20  3:02     ` David Miller
2018-05-21 20:03       ` [PATCH net-next v2] " Vlad Buslov
2018-05-22 12:50         ` Jamal Hadi Salim
2018-05-23  1:10         ` Cong Wang
2018-05-23  6:57           ` Vlad Buslov
2018-05-23  7:32         ` Jiri Pirko [this message]
2018-05-23  8:52           ` [PATCH net-next v3] " Vlad Buslov
2018-05-23 23:14             ` Cong Wang
2018-05-24 16:54               ` Vlad Buslov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523073239.GC3155@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vladbu@mellanox.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.