All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit branch/next] systemd: add optional dependency on libidn2
Date: Wed, 23 May 2018 08:01:43 +0200	[thread overview]
Message-ID: <20180523080143.65f792f9@windsurf> (raw)
In-Reply-To: <CAPi7W80i7hYppmX2fnOTcZEThcXT7cA538Aaz9bOFBHdmJMPCQ@mail.gmail.com>

Hello,

On Tue, 22 May 2018 23:49:38 +0200, Fabrice Fontaine wrote:

> > > -SYSTEMD_CONF_OPTS += -Dlibidn=false
> > > +SYSTEMD_CONF_OPTS += -Dlibidn=false -Dlibidn2=true  
> >
> >  Shouldn't this be -Dlibidn2=false ?
> >  
> Indeed, you're completly right, thanks for spotting the mistake.

It's not your fault I believe, but mine. I reworked this patch of your
patch when applying and got it wrong.

I've pushed a commit that fixes that. Thanks Arnout for spotting, and
sorry Fabrice for this mistake :/

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-05-23  6:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-20 14:12 [Buildroot] [git commit branch/next] systemd: add optional dependency on libidn2 Thomas Petazzoni
2018-05-22 21:17 ` Arnout Vandecappelle
2018-05-22 21:49   ` Fabrice Fontaine
2018-05-23  6:01     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523080143.65f792f9@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.