From: James Hogan <jhogan@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] MIPS: PCI: Use dev_printk() when possible
Date: Wed, 23 May 2018 09:14:48 +0100 [thread overview]
Message-ID: <20180523081447.GA15645@jamesdev> (raw)
In-Reply-To: <152699470263.162686.16975145205315900817.stgit@bhelgaas-glaptop.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]
On Tue, May 22, 2018 at 08:11:42AM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Use the pci_info() and pci_err() wrappers for dev_printk() when possible.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> arch/mips/pci/pci-legacy.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/mips/pci/pci-legacy.c b/arch/mips/pci/pci-legacy.c
> index 0c65c38e05d6..73643e80f02d 100644
> --- a/arch/mips/pci/pci-legacy.c
> +++ b/arch/mips/pci/pci-legacy.c
> @@ -263,9 +263,7 @@ static int pcibios_enable_resources(struct pci_dev *dev, int mask)
> (!(r->flags & IORESOURCE_ROM_ENABLE)))
> continue;
> if (!r->start && r->end) {
> - printk(KERN_ERR "PCI: Device %s not available "
> - "because of resource collisions\n",
> - pci_name(dev));
> + pci_err(dev, "can't enable device: resource collisions\n");
The pedantic side of me wants to point out that you could wrap that line
after the comma to keep it within 80 columns.
Either way though:
Acked-by: James Hogan <jhogan@kernel.org>
Cheers
James
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2018-05-23 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 13:11 [PATCH v1] MIPS: PCI: Use dev_printk() Bjorn Helgaas
2018-05-22 13:11 ` [PATCH v1] MIPS: PCI: Use dev_printk() when possible Bjorn Helgaas
2018-05-23 8:14 ` James Hogan [this message]
2018-05-23 13:48 ` Bjorn Helgaas
2018-05-30 16:50 ` [PATCH v1] MIPS: PCI: Use dev_printk() Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523081447.GA15645@jamesdev \
--to=jhogan@kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-pci@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.