diff for duplicates of <20180523211709.GA63112@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 1a32875..33c3207 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,13 +3,13 @@ On Wed, May 23, 2018 at 11:56:36AM -0400, David Miller wrote: > Date: Wed, 23 May 2018 15:57:08 +0200 > > > I'd rather add -> > + if (cmd = PPPIOCDETACH) { +> > + if (cmd == PPPIOCDETACH) { > > + err = -EINVAL; > > + goto out; > > + } > > > > Making PPPIOCDETACH unknown to ppp_generic means that the ioctl would -> > be handled by the underlying channel when pf->kind = CHANNEL (see the +> > be handled by the underlying channel when pf->kind == CHANNEL (see the > > chan->ops->ioctl() call further down). That shouldn't be a problem per > > se, but even though PPPIOCDETACH is unsupported, I feel that it should > > remain a ppp_generic thing. I don't really want its value to be reused diff --git a/a/content_digest b/N1/content_digest index c78e9cb..7c17490 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\020180523.115636.2241611659399097483.davem@davemloft.net\0" "From\0Eric Biggers <ebiggers3@gmail.com>\0" "Subject\0Re: [PATCH] ppp: remove the PPPIOCDETACH ioctl\0" - "Date\0Wed, 23 May 2018 21:17:09 +0000\0" + "Date\0Wed, 23 May 2018 14:17:09 -0700\0" "To\0David Miller <davem@davemloft.net>\0" "Cc\0g.nault@alphalink.fr" linux-ppp@vger.kernel.org @@ -21,13 +21,13 @@ "> Date: Wed, 23 May 2018 15:57:08 +0200\n" "> \n" "> > I'd rather add\n" - "> > +\tif (cmd = PPPIOCDETACH) {\n" + "> > +\tif (cmd == PPPIOCDETACH) {\n" "> > +\t\terr = -EINVAL;\n" "> > +\t\tgoto out;\n" "> > +\t}\n" "> > \n" "> > Making PPPIOCDETACH unknown to ppp_generic means that the ioctl would\n" - "> > be handled by the underlying channel when pf->kind = CHANNEL (see the\n" + "> > be handled by the underlying channel when pf->kind == CHANNEL (see the\n" "> > chan->ops->ioctl() call further down). That shouldn't be a problem per\n" "> > se, but even though PPPIOCDETACH is unsupported, I feel that it should\n" "> > remain a ppp_generic thing. I don't really want its value to be reused\n" @@ -48,4 +48,4 @@ "\n" - Eric -c528f9461ff84194ec87790db174ae2f64dfa16b67b9c9e73a477a1c34a5f53b +8e53efc582670f722aa38ddc09377205a1fc2dedc436289304fc3d644e22b4b0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.