From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: [PATCH 4/6] openvswitch: convert to genradix Date: Wed, 23 May 2018 18:24:28 -0400 Message-ID: <20180523222428.GC23040@kmo-pixel> References: <20180523011821.12165-1-kent.overstreet@gmail.com> <20180523011821.12165-4-kent.overstreet@gmail.com> <20180523123401.GB19987@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180523123401.GB19987-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: ovs-dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org To: Matthew Wilcox Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Artur Paszkiewicz List-Id: linux-raid.ids On Wed, May 23, 2018 at 05:34:01AM -0700, Matthew Wilcox wrote: > On Tue, May 22, 2018 at 09:18:19PM -0400, Kent Overstreet wrote: > > the new generic radix trees have a simpler API and implementation, and > > no limitations on number of elements, so all flex_array users are being > > converted > > This doesn't really feel like it should be a flexarray / genradix user. > It just wants to allocate a lot of buckets and use them. Maybe kvmalloc > is the right approach for this user of flexarray? Yeah probably, or a rhashtable. Now that you mention it, I think the md code should definitely be using kvmalloc too. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kent.overstreet@gmail.com (Kent Overstreet) Date: Wed, 23 May 2018 18:24:28 -0400 Subject: [PATCH 4/6] openvswitch: convert to genradix In-Reply-To: <20180523123401.GB19987@bombadil.infradead.org> References: <20180523011821.12165-1-kent.overstreet@gmail.com> <20180523011821.12165-4-kent.overstreet@gmail.com> <20180523123401.GB19987@bombadil.infradead.org> Message-ID: <20180523222428.GC23040@kmo-pixel> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On Wed, May 23, 2018 at 05:34:01AM -0700, Matthew Wilcox wrote: > On Tue, May 22, 2018 at 09:18:19PM -0400, Kent Overstreet wrote: > > the new generic radix trees have a simpler API and implementation, and > > no limitations on number of elements, so all flex_array users are being > > converted > > This doesn't really feel like it should be a flexarray / genradix user. > It just wants to allocate a lot of buckets and use them. Maybe kvmalloc > is the right approach for this user of flexarray? Yeah probably, or a rhashtable. Now that you mention it, I think the md code should definitely be using kvmalloc too. -- To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id w4NMPIHY011448 for ; Wed, 23 May 2018 18:25:18 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by USFBF3ID15.oob.disa.mil (Postfix) with SMTP id 40rnBY6TMKz4KWLJ for ; Wed, 23 May 2018 22:24:53 +0000 (UTC) Received: from USFB3CPA05_EEMSG_MP27.eemsg.mil (unknown [192.168.16.22]) by USFBF3ID15.oob.disa.mil (Postfix) with ESMTP id 40rnBY4gPbz4KWKm for ; Wed, 23 May 2018 22:24:53 +0000 (UTC) Received: by mail-qk0-f194.google.com with SMTP id z75-v6so18812405qkb.6 for ; Wed, 23 May 2018 15:24:32 -0700 (PDT) Date: Wed, 23 May 2018 18:24:28 -0400 From: Kent Overstreet To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, gregkh@linuxfoundation.org, linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, dev@openvswitch.org, shli@kernel.org, linux-raid@vger.kernel.org, Artur Paszkiewicz Message-ID: <20180523222428.GC23040@kmo-pixel> References: <20180523011821.12165-1-kent.overstreet@gmail.com> <20180523011821.12165-4-kent.overstreet@gmail.com> <20180523123401.GB19987@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180523123401.GB19987@bombadil.infradead.org> Subject: Re: [PATCH 4/6] openvswitch: convert to genradix List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: On Wed, May 23, 2018 at 05:34:01AM -0700, Matthew Wilcox wrote: > On Tue, May 22, 2018 at 09:18:19PM -0400, Kent Overstreet wrote: > > the new generic radix trees have a simpler API and implementation, and > > no limitations on number of elements, so all flex_array users are being > > converted > > This doesn't really feel like it should be a flexarray / genradix user. > It just wants to allocate a lot of buckets and use them. Maybe kvmalloc > is the right approach for this user of flexarray? Yeah probably, or a rhashtable. Now that you mention it, I think the md code should definitely be using kvmalloc too.