From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ganesh Goudar Date: Thu, 24 May 2018 15:48:55 +0530 Subject: [Intel-wired-lan] [PATCH v6 0/5] PCI: Improve PCIe link status reporting In-Reply-To: <20180523214651.GE150632@bhelgaas-glaptop.roam.corp.google.com> References: <152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com> <20180523214651.GE150632@bhelgaas-glaptop.roam.corp.google.com> Message-ID: <20180524101853.GA4913@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Wednesday, May 05/23/18, 2018 at 16:46:51 -0500, Bjorn Helgaas wrote: > [+to Davem] > > On Thu, May 03, 2018 at 03:00:07PM -0500, Bjorn Helgaas wrote: > > This is based on Tal's recent work to unify the approach for reporting PCIe > > link speed/width and whether the device is being limited by a slower > > upstream link. > > > > The new pcie_print_link_status() interface appeared in v4.17-rc1; see > > 9e506a7b5147 ("PCI: Add pcie_print_link_status() to log link speed and > > whether it's limited"). > > > > That's a good way to replace use of pcie_get_minimum_link(), which gives > > misleading results when a path contains both a fast, narrow link and a > > slow, wide link: it reports the equivalent of a slow, narrow link. > > > > This series removes the remaining uses of pcie_get_minimum_link() and then > > removes the interface itself. I'd like to merge them all through the PCI > > tree to make the removal easy. > > > > This does change the dmesg reporting of link speeds, and in the ixgbe case, > > it changes the reporting from KERN_WARN level to KERN_INFO. If that's an > > issue, let's talk about it. I'm hoping the reduce code size, improved > > functionality, and consistency across drivers is enough to make this > > worthwhile. > > > > --- > > > > Bjorn Helgaas (5): > > bnx2x: Report PCIe link properties with pcie_print_link_status() > > bnxt_en: Report PCIe link properties with pcie_print_link_status() > > cxgb4: Report PCIe link properties with pcie_print_link_status() > > ixgbe: Report PCIe link properties with pcie_print_link_status() > > PCI: Remove unused pcie_get_minimum_link() > > > > > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 23 ++----- > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 19 ------ > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 75 ---------------------- > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 47 -------------- > > drivers/pci/pci.c | 43 ------------- > > include/linux/pci.h | 2 - > > 6 files changed, 9 insertions(+), 200 deletions(-) > > I applied all of these on pci/enumeration for v4.18. If you'd rather take > them, Dave, let me know and I'll drop them. > > I solicited more acks, but only heard from Jeff. Sorry for that, Thanks for cxgb4 changes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 24 May 2018 15:48:55 +0530 From: Ganesh Goudar To: Bjorn Helgaas Cc: Jeff Kirsher , Michael Chan , Ariel Elior , "David S. Miller" , linux-pci@vger.kernel.org, everest-linux-l2@cavium.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tal Gilboa , Tariq Toukan , Jacob Keller , Jakub Kicinski Subject: Re: [PATCH v6 0/5] PCI: Improve PCIe link status reporting Message-ID: <20180524101853.GA4913@chelsio.com> References: <152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com> <20180523214651.GE150632@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180523214651.GE150632@bhelgaas-glaptop.roam.corp.google.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wednesday, May 05/23/18, 2018 at 16:46:51 -0500, Bjorn Helgaas wrote: > [+to Davem] > > On Thu, May 03, 2018 at 03:00:07PM -0500, Bjorn Helgaas wrote: > > This is based on Tal's recent work to unify the approach for reporting PCIe > > link speed/width and whether the device is being limited by a slower > > upstream link. > > > > The new pcie_print_link_status() interface appeared in v4.17-rc1; see > > 9e506a7b5147 ("PCI: Add pcie_print_link_status() to log link speed and > > whether it's limited"). > > > > That's a good way to replace use of pcie_get_minimum_link(), which gives > > misleading results when a path contains both a fast, narrow link and a > > slow, wide link: it reports the equivalent of a slow, narrow link. > > > > This series removes the remaining uses of pcie_get_minimum_link() and then > > removes the interface itself. I'd like to merge them all through the PCI > > tree to make the removal easy. > > > > This does change the dmesg reporting of link speeds, and in the ixgbe case, > > it changes the reporting from KERN_WARN level to KERN_INFO. If that's an > > issue, let's talk about it. I'm hoping the reduce code size, improved > > functionality, and consistency across drivers is enough to make this > > worthwhile. > > > > --- > > > > Bjorn Helgaas (5): > > bnx2x: Report PCIe link properties with pcie_print_link_status() > > bnxt_en: Report PCIe link properties with pcie_print_link_status() > > cxgb4: Report PCIe link properties with pcie_print_link_status() > > ixgbe: Report PCIe link properties with pcie_print_link_status() > > PCI: Remove unused pcie_get_minimum_link() > > > > > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 23 ++----- > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 19 ------ > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 75 ---------------------- > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 47 -------------- > > drivers/pci/pci.c | 43 ------------- > > include/linux/pci.h | 2 - > > 6 files changed, 9 insertions(+), 200 deletions(-) > > I applied all of these on pci/enumeration for v4.18. If you'd rather take > them, Dave, let me know and I'll drop them. > > I solicited more acks, but only heard from Jeff. Sorry for that, Thanks for cxgb4 changes.