From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops
Date: Thu, 24 May 2018 15:30:44 +0200 [thread overview]
Message-ID: <20180524133044.GG24557@lunn.ch> (raw)
In-Reply-To: <1527160318-10958-5-git-send-email-vladimir_zapolskiy@mentor.com>
On Thu, May 24, 2018 at 02:11:56PM +0300, Vladimir Zapolskiy wrote:
> The change fixes a sleep in atomic context issue, which can be
> always triggered by running 'ethtool -r' command, because
> phy_start_aneg() protects phydev fields by a mutex.
>
> Another note is that the change implicitly replaces phy_start_aneg()
> with a newer phy_restart_aneg().
>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2018-05-24 13:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 11:11 [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers Vladimir Zapolskiy
2018-05-24 11:11 ` [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops Vladimir Zapolskiy
2018-05-24 13:22 ` Andrew Lunn
2018-05-24 14:11 ` Vladimir Zapolskiy
2018-05-24 14:11 ` Vladimir Zapolskiy
2018-05-24 16:18 ` Sergei Shtylyov
2018-05-24 16:44 ` Andrew Lunn
2018-05-24 17:01 ` Sergei Shtylyov
2018-05-24 17:23 ` Andrew Lunn
2018-05-25 6:05 ` Vladimir Zapolskiy
2018-05-25 6:05 ` Vladimir Zapolskiy
2018-05-26 16:56 ` Sergei Shtylyov
2018-05-26 16:56 ` Sergei Shtylyov
2018-05-26 17:51 ` Sergei Shtylyov
2018-05-24 11:11 ` [PATCH 2/6] ravb: remove custom .get_link_ksettings " Vladimir Zapolskiy
2018-05-26 17:07 ` Sergei Shtylyov
2018-05-24 11:11 ` [PATCH 3/6] ravb: remove custom .set_link_ksettings " Vladimir Zapolskiy
2018-05-24 13:29 ` Andrew Lunn
2018-05-24 14:06 ` Vladimir Zapolskiy
2018-05-24 14:06 ` Vladimir Zapolskiy
2018-05-26 19:50 ` Sergei Shtylyov
2018-05-28 9:51 ` Vladimir Zapolskiy
2018-05-28 9:51 ` Vladimir Zapolskiy
2018-06-03 15:42 ` Sergei Shtylyov
2018-06-04 11:07 ` Vladimir Zapolskiy
2018-06-04 11:07 ` Vladimir Zapolskiy
2018-06-06 20:34 ` Sergei Shtylyov
2018-05-24 11:11 ` [PATCH 4/6] sh_eth: remove custom .nway_reset " Vladimir Zapolskiy
2018-05-24 13:30 ` Andrew Lunn [this message]
2018-05-26 18:46 ` Sergei Shtylyov
2018-05-26 19:22 ` Sergei Shtylyov
2018-05-24 11:14 ` [PATCH 5/6] sh_eth: remove custom .get_link_ksettings " Vladimir Zapolskiy
2018-05-24 11:14 ` [PATCH 6/6] sh_eth: remove custom .set_link_ksettings " Vladimir Zapolskiy
2018-05-24 13:31 ` [PATCH 5/6] sh_eth: remove custom .get_link_ksettings " Andrew Lunn
2018-05-24 16:40 ` [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers Sergei Shtylyov
2018-05-24 17:24 ` Sergei Shtylyov
2018-05-25 6:25 ` Vladimir Zapolskiy
2018-05-25 6:25 ` Vladimir Zapolskiy
2018-05-26 17:31 ` Sergei Shtylyov
2018-05-25 8:11 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524133044.GG24557@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.