From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: hub: Per-port setting to use old enumeration scheme From: Greg Kroah-Hartman Message-Id: <20180524162157.GA26662@kroah.com> Date: Thu, 24 May 2018 18:21:57 +0200 To: Nicolas Boichat Cc: Alan Stern , linux-usb@vger.kernel.org, Mathias Nyman , Felipe Balbi , Eugene Korenevsky , Peter Chen , Daniel Drake , Joe Perches , Johan Hovold , Richard Leitner , lkml , Guenter Roeck List-ID: T24gVGh1LCBNYXkgMjQsIDIwMTggYXQgMDc6NDI6MDBBTSArMDgwMCwgTmljb2xhcyBCb2ljaGF0 IHdyb3RlOgo+IE9uIFRodSwgTWF5IDI0LCAyMDE4IGF0IDEyOjM5IEFNLCBHcmVnIEtyb2FoLUhh cnRtYW4KPiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+IHdyb3RlOgo+ID4gT24gV2VkLCBN YXkgMjMsIDIwMTggYXQgMTA6MDM6NTVBTSAtMDQwMCwgQWxhbiBTdGVybiB3cm90ZToKPiA+PiBP biBXZWQsIDIzIE1heSAyMDE4LCBOaWNvbGFzIEJvaWNoYXQgd3JvdGU6Cj4gPj4KPiA+PiA+IFRo ZSAib2xkIiBlbnVtZXJhdGlvbiBzY2hlbWUgaXMgY29uc2lkZXJhYmx5IGZhc3RlciAoaXQgdGFr ZXMKPiA+PiA+IH4yOTRtcyBpbnN0ZWFkIG9mIH40MzltcyB0byBnZXQgdGhlIGRlc2NyaXB0b3Ip Lgo+ID4+ID4KPiA+PiA+IEl0IGlzIGN1cnJlbnRseSBvbmx5IHBvc3NpYmxlIHRvIHVzZSB0aGUg b2xkIHNjaGVtZSBnbG9iYWxseQo+ID4+ID4gKC9zeXMvbW9kdWxlL3VzYmNvcmUvcGFyYW1ldGVy cy9vbGRfc2NoZW1lX2ZpcnN0KSwgd2hpY2ggaXMgbm90Cj4gPj4gPiBkZXNpcmFibGUgYXMgdGhl IG5ldyBzY2hlbWUgd2FzIGludHJvZHVjZWQgdG8gaW5jcmVhc2UgY29tcGF0aWJpbGl0eQo+ID4+ ID4gd2l0aCBtb3JlIGRldmljZXMuCj4gPj4gPgo+ID4+ID4gSG93ZXZlciwgaW4gb3VyIGNhc2Us IHdlIGNhcmUgYWJvdXQgdGltZS10by1hY3RpdmUgZm9yIGEgc3BlY2lmaWMKPiA+PiA+IFVTQiBk ZXZpY2UgKHdoaWNoIHdlIG1ha2UgdGhlIGZpcm13YXJlIGZvciksIG9uIGEgc3BlY2lmaWMgcG9y dAo+ID4+ID4gKHRoYXQgaXMgcG9nby1waW4gYmFzZWQ6IG5vdCBhIHN0YW5kYXJkIFVTQiBwb3J0 KS4gVGhpcyBuZXcKPiA+PiA+IHN5c2ZzIG9wdGlvbiBtYWtlcyBpdCBwb3NzaWJsZSB0byB1c2Ug dGhlIG9sZCBzY2hlbWUgb24gYSBzaW5nbGUKPiA+PiA+IHBvcnQgb25seS4KPiA+PiA+Cj4gPj4g PiBTaWduZWQtb2ZmLWJ5OiBOaWNvbGFzIEJvaWNoYXQgPGRyaW5rY2F0QGNocm9taXVtLm9yZz4K PiA+PiA+IC0tLQo+ID4+ID4KPiA+PiA+IFRoZXJlIGFyZSBvdGhlciAicXVpcmtzIiB0aGF0IHdl IGNvdWxkIGFkZCB0byByZWR1Y2UgZnVydGhlcgo+ID4+ID4gZW51bWVyYXRpb24gdGltZSAoZS5n LiByZWR1Y2UgVVNCIGRlYm91bmNlIHRpbWUsIHJlZHVjZSBUUlNUUkNZCj4gPj4gPiB0byAxMG1z IGluc3RlYWQgb2YgNTBtcyBhcyB1c2VkIGN1cnJlbnRseSksIGJ1dCB0aGUgbG9naWMgaXMgcXVp dGUKPiA+PiA+IHNpbWlsYXIsIHNvIGl0J2QgYmUgZ29vZCB0byBoYXZlIHRoaXMgcmV2aWV3ZWQg Zmlyc3QuCj4gPj4KPiA+PiBJJ20gbm90IG9wcG9zZWQgdG8gdGhlIGlkZWEgaW4gcHJpbmNpcGxl LCBhbHRob3VnaCBJIGRvbid0IGxpa2UgeW91cgo+ID4+IGltcGxlbWVudGF0aW9uIGJlY2F1c2Ug aXQgYnJlYWtzIHRoZSBvcmlnaW5hbCBvbGRfc2NoZW1lX2ZpcnN0Cj4gPj4gcGFyYW1ldGVyLgo+ IAo+IEkgZG9uJ3QgdGhpbmsgaXQgYnJlYWtzIHRoZSBvcmlnaW5hbCBwYXJhbWV0ZXI/IEkgbWVh biwKPiAvc3lzL21vZHVsZS91c2Jjb3JlL3BhcmFtZXRlcnMvb2xkX3NjaGVtZV9maXJzdCBpcyBz dGlsbCBhIGdsb2JhbAo+IGRlZmF1bHQsIHdoaWxlIGJpdCAwIG9mIC9zeXMvYnVzL3VzYi9kZXZp Y2VzL3gveS96L3F1aXJrcyBiZWNvbWVzIGEKPiBwb3J0LXNwZWNpZmljIG92ZXJyaWRlLgo+IAo+ ID4+IExldCdzIHNlZSB3aGF0IHNvbWUgb3RoZXIgcGVvcGxlIHRoaW5rLgo+ID4+Cj4gPj4gWW91 cnMgaXMgYSByYXRoZXIgc3BlY2lhbCBjYXNlLCBiZWNhdXNlIHlvdSBrbm93IGV4YWN0bHkgd2hh dCBkZXZpY2UKPiA+PiB3aWxsIGJlIGF0dGFjaGVkIHRvIGEgc3BlY2lmaWMgcG9ydC4gIFN0aWxs LCBJIGNhbiBzZWUgdGhhdCBzb3J0IG9mCj4gPj4gdGhpbmcgaGFwcGVuaW5nIGluIGNvbnN0cmFp bmVkIGFuZCBzcGVjaWFsLXB1cnBvc2Ugc2V0dGluZ3MuCj4gPj4KPiA+PiBIb3cgZG8geW91IGFy cmFuZ2UgdG8gc2V0IHRoZSBuZXcgcXVpcmsgYmVmb3JlIHRoZSBkZXZpY2UgaXMKPiA+PiBkaXNj b3ZlcmVkPwo+ID4KPiA+IFllYWgsIHRoaXMgbGFzdCBxdWVzdGlvbiBpcyB3aGF0IEkgaGFkIHdo ZW4gbG9va2luZyBhdCB0aGlzLiAgT3IgZG9lcyBpdAo+ID4gbm90IG1hdHRlciBhdCBmaXJzdCBi b290IGFuZCBvbmx5IG1hdHRlcnMgZm9yIHdha2UtdXA/Cj4gCj4gSXQgZG9lcyBub3QgbWF0dGVy IG9uIGJvb3QsIHdlIGhhdmUgcGxlbnR5IG9mIHRpbWUgdG8gZW51bWVyYXRlIHRoZQo+IGRldmlj ZS4gV2UgdXNlIFVTQiAoYXV0by0pc3VzcGVuZCBhbmQgcmVtb3RlIHdha2UsIHNvIG5vCj4gcmUt ZW51bWVyYXRpb24gdGhlcmUgZWl0aGVyLiBJdCBvbmx5IG1hdHRlcnMgb24gdW5wbHVnL3JlcGx1 ZyB3aGVyZQo+IHRoZSBkZXZpY2UgbmVlZHMgdG8gYmUgcmUtZW51bWVyYXRlZC4KCkhvdyBkb2Vz IHRoaXMgZGV2aWNlIGdldCB1bnBsdWdnZWQvcmVwbHVnZ2VkIGlmIGl0IGlzIGNvbm5lY3RlZCBk aXJlY3RseQp0byB0aGUgZGV2aWNlPwoKPiBTb21ld2hlcmUgaW4gYW4gaW5pdCBzY3JpcHQsIHdl IHdvdWxkIGRvIHRoaXMgKHdlIGtub3cgaW4gYWR2YW5jZSB0aGF0Cj4gdXNiMSBwb3J0MiBpcyB0 aGUgYnVzL3BvcnQgd2hlcmUgd2UgaGF2ZSBvdXIgcG9nby1waW4gVVNCIGludGVyZmFjZSwKPiBz byB3ZSBjYW4gaGFyZC1jb2RlIHRoZSBwYXRoKToKPiBlY2hvIDEgPiAvc3lzL2J1cy91c2IvZGV2 aWNlcy91c2IxLzEtMDoxLjAvdXNiMS1wb3J0Mi9xdWlya3MKPiAKPiBXZSBjb3VsZCB0cnkgdG8g YWRkIEFDUEkgc3VwcG9ydCAoanVzdCBsaWtlIGNvbm5lY3RfdHlwZSksIGJ1dCB3ZQo+IGRvbid0 IHN0cmljdGx5IG5lZWQgaXQgZm9yIG91ciBhcHBsaWNhdGlvbi4KCklzbid0IHRoZXJlIGFuICJp bnRlcm5hbCIgQUNQSSBmbGFnIGZvciBVU0IgcG9ydHMsIG9yIGlzIHRoYXQKd2hhdCBjb25uZWN0 X3R5cGUgaXM/ICBXaHkgd291bGRuJ3QgdGhhdCB3b3JrIGhlcmUgaW5zdGVhZD8KCnRoYW5rcywK CmdyZWcgay1oCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGlu ZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFq b3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdl ci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033601AbeEXQWT (ORCPT ); Thu, 24 May 2018 12:22:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:46542 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030948AbeEXQWR (ORCPT ); Thu, 24 May 2018 12:22:17 -0400 Date: Thu, 24 May 2018 18:21:57 +0200 From: Greg Kroah-Hartman To: Nicolas Boichat Cc: Alan Stern , linux-usb@vger.kernel.org, Mathias Nyman , Felipe Balbi , Eugene Korenevsky , Peter Chen , Daniel Drake , Joe Perches , Johan Hovold , Richard Leitner , lkml , Guenter Roeck Subject: Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme Message-ID: <20180524162157.GA26662@kroah.com> References: <20180523021656.122455-1-drinkcat@chromium.org> <20180523163936.GE12456@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 24, 2018 at 07:42:00AM +0800, Nicolas Boichat wrote: > On Thu, May 24, 2018 at 12:39 AM, Greg Kroah-Hartman > wrote: > > On Wed, May 23, 2018 at 10:03:55AM -0400, Alan Stern wrote: > >> On Wed, 23 May 2018, Nicolas Boichat wrote: > >> > >> > The "old" enumeration scheme is considerably faster (it takes > >> > ~294ms instead of ~439ms to get the descriptor). > >> > > >> > It is currently only possible to use the old scheme globally > >> > (/sys/module/usbcore/parameters/old_scheme_first), which is not > >> > desirable as the new scheme was introduced to increase compatibility > >> > with more devices. > >> > > >> > However, in our case, we care about time-to-active for a specific > >> > USB device (which we make the firmware for), on a specific port > >> > (that is pogo-pin based: not a standard USB port). This new > >> > sysfs option makes it possible to use the old scheme on a single > >> > port only. > >> > > >> > Signed-off-by: Nicolas Boichat > >> > --- > >> > > >> > There are other "quirks" that we could add to reduce further > >> > enumeration time (e.g. reduce USB debounce time, reduce TRSTRCY > >> > to 10ms instead of 50ms as used currently), but the logic is quite > >> > similar, so it'd be good to have this reviewed first. > >> > >> I'm not opposed to the idea in principle, although I don't like your > >> implementation because it breaks the original old_scheme_first > >> parameter. > > I don't think it breaks the original parameter? I mean, > /sys/module/usbcore/parameters/old_scheme_first is still a global > default, while bit 0 of /sys/bus/usb/devices/x/y/z/quirks becomes a > port-specific override. > > >> Let's see what some other people think. > >> > >> Yours is a rather special case, because you know exactly what device > >> will be attached to a specific port. Still, I can see that sort of > >> thing happening in constrained and special-purpose settings. > >> > >> How do you arrange to set the new quirk before the device is > >> discovered? > > > > Yeah, this last question is what I had when looking at this. Or does it > > not matter at first boot and only matters for wake-up? > > It does not matter on boot, we have plenty of time to enumerate the > device. We use USB (auto-)suspend and remote wake, so no > re-enumeration there either. It only matters on unplug/replug where > the device needs to be re-enumerated. How does this device get unplugged/replugged if it is connected directly to the device? > Somewhere in an init script, we would do this (we know in advance that > usb1 port2 is the bus/port where we have our pogo-pin USB interface, > so we can hard-code the path): > echo 1 > /sys/bus/usb/devices/usb1/1-0:1.0/usb1-port2/quirks > > We could try to add ACPI support (just like connect_type), but we > don't strictly need it for our application. Isn't there an "internal" ACPI flag for USB ports, or is that what connect_type is? Why wouldn't that work here instead? thanks, greg k-h