From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Joel Fernandes <joelaf@google.com>,
linux-kernel@vger.kernel.org,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
Peter Zilstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Boqun Feng <boqun.feng@gmail.com>,
byungchul.park@lge.com, kernel-team@android.com,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH 1/4] rcu: Speed up calling of RCU tasks callbacks
Date: Thu, 24 May 2018 15:38:39 -0700 [thread overview]
Message-ID: <20180524223839.GU3803@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180524174752.0928d562@gandalf.local.home>
On Thu, May 24, 2018 at 05:47:52PM -0400, Steven Rostedt wrote:
> On Wed, 23 May 2018 13:04:58 -0700
> "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
>
> > Looks plausible to me!
> >
>
> BTW looking at the code:
>
> > /* Invoke the callbacks. */
> > while (list) {
> > next = list->next;
> > local_bh_disable();
> > list->func(list);
> > local_bh_enable();
> > list = next;
> > cond_resched();
> > }
> > schedule_timeout_uninterruptible(HZ/10);
>
> What's the purpose of this final sleep?
To avoid any possibility of rcu_tasks_kthread() getting into a tight loop.
Thanx, Paul
next prev parent reply other threads:[~2018-05-24 22:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 6:38 [PATCH 0/4] cleanups, fixes for rcu/dev Joel Fernandes
2018-05-23 6:38 ` [PATCH 1/4] rcu: Speed up calling of RCU tasks callbacks Joel Fernandes
2018-05-23 15:57 ` Paul E. McKenney
2018-05-23 16:45 ` Steven Rostedt
2018-05-23 17:03 ` Paul E. McKenney
2018-05-23 19:13 ` Steven Rostedt
2018-05-23 20:04 ` Paul E. McKenney
2018-05-23 21:51 ` Joel Fernandes
2018-05-24 0:51 ` Joel Fernandes
2018-05-24 1:35 ` Steven Rostedt
2018-05-24 21:47 ` Steven Rostedt
2018-05-24 22:38 ` Paul E. McKenney [this message]
2018-05-24 22:42 ` Steven Rostedt
2018-07-17 9:11 ` [tip:core/rcu] rcu: Add comment to the last sleep in the rcu tasks loop tip-bot for Steven Rostedt (VMware)
2018-07-17 9:11 ` [tip:core/rcu] rcu: Speed up calling of RCU tasks callbacks tip-bot for Steven Rostedt (VMware)
2018-05-23 6:38 ` [PATCH 2/4] rcu: Add comment documenting how rcu_seq_snap works Joel Fernandes
2018-05-23 16:04 ` Paul E. McKenney
2018-05-23 6:38 ` [PATCH 3/4] rcu: Use better variable names in funnel locking loop Joel Fernandes
2018-05-23 16:06 ` Paul E. McKenney
2018-05-23 19:23 ` Paul E. McKenney
2018-05-24 0:54 ` Joel Fernandes
2018-05-24 1:27 ` Paul E. McKenney
2018-05-23 6:38 ` [PATCH 4/4] rcu: Identify grace period is in progress as we advance up the tree Joel Fernandes
2018-05-23 16:06 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524223839.GU3803@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=boqun.feng@gmail.com \
--cc=byungchul.park@lge.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=joelaf@google.com \
--cc=josh@joshtriplett.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.