From: Tiwei Bie <tiwei.bie@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: maxime.coquelin@redhat.com, john.mcnamara@intel.com,
marko.kovacevic@intel.com, dev@dpdk.org,
Wenzhuo Lu <wenzhuo.lu@intel.com>
Subject: Re: [PATCH] doc: address the offload API changes for virtio guide
Date: Fri, 25 May 2018 16:54:54 +0800 [thread overview]
Message-ID: <20180525085454.GA15338@debian> (raw)
In-Reply-To: <20180525082736.GA4935@debian>
On Fri, May 25, 2018 at 04:27:36PM +0800, Tiwei Bie wrote:
> On Fri, May 25, 2018 at 09:20:08AM +0100, Ferruh Yigit wrote:
> > On 5/25/2018 7:17 AM, Tiwei Bie wrote:
> > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> >
> > <...>
> >
> > > @@ -252,7 +252,7 @@ The corresponding callbacks are:
> > > Example of using the vector version of the virtio poll mode driver in
> > > ``testpmd``::
> > >
> > > - testpmd -l 0-2 -n 4 -- -i --txqflags=0xF01 --rxq=1 --txq=1 --nb-cores=1
> > > + testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1
> >
> > Thanks, I missed this one, there are a few occurrence of "--txqflags" [1].
> >
> > Tiwei would you mind sending another patch for those?
> > In below context "--txqflags" is not really focus, I think we can just remove it
> > without replacing with "--tx-offloads"
>
> No problem. I will do it now. :)
>
> Best regards,
> Tiwei Bie
>
> >
> > Thanks,
> > ferruh
> >
> >
> > [1]
> > doc/guides/contributing/documentation.rst: -- -i --txqflags=0x0
> > --enable-hw-vlan --enable-lro \
> > doc/guides/howto/vfd.rst: testpmd -l 0-7 -n 4 -- -i --txqflags=0
> > doc/guides/howto/vfd.rst: testpmd -l 0-7 -n 4 -- -i --txqflags=0
Hmm.. After a closer look, I think above two --txqflags can't
be simply removed. In this guide, it needs to demonstrate these
offloads, e.g. VLAN insertion:
http://dpdk.org/browse/dpdk/tree/doc/guides/howto/vfd.rst?h=v18.05-rc5#n155
Right now, unfortunately I'm being busy with preparing a QEMU
patch set which I need to get it done today. So I'm afraid that
I don't have time to look into this today.. I'm Sorry.. :(
Best regards,
Tiwei Bie
> > doc/guides/howto/virtio_user_as_exceptional_path.rst: -- -i
> > --txqflags=0x0 --enable-lro \
> > doc/guides/howto/virtio_user_as_exceptional_path.rst: -- -i
> > --txqflags=0x0 --enable-lro \
> > doc/guides/howto/virtio_user_for_container_networking.rst: -- -i
> > --txqflags=0xf00 --disable-hw-vlan
next prev parent reply other threads:[~2018-05-25 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 6:17 [PATCH] doc: address the offload API changes for virtio guide Tiwei Bie
2018-05-25 7:16 ` Maxime Coquelin
2018-05-25 8:41 ` Ferruh Yigit
2018-05-25 8:20 ` Ferruh Yigit
2018-05-25 8:27 ` Tiwei Bie
2018-05-25 8:54 ` Tiwei Bie [this message]
2018-05-25 9:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525085454.GA15338@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.