From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v2 7/8] iommu: Remove IOMMU_OF_DECLARE Date: Fri, 25 May 2018 12:31:05 +0100 Message-ID: <20180525113104.GA3255@arm.com> References: <20180524175024.19874-1-robh@kernel.org> <20180524175024.19874-8-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180524175024.19874-8-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Rob Herring Cc: Ulf Hansson , Heiko Stuebner , Linus Walleij , Bjorn Andersson , Frank Rowand , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kevin Hilman , Alexander Graf , Krzysztof Kozlowski , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kukjin Kim , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, boot-architecture-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org On Thu, May 24, 2018 at 12:50:23PM -0500, Rob Herring wrote: > Now that we use the driver core to stop deferred probe for missing > drivers, IOMMU_OF_DECLARE can be removed. > > This is slightly less optimal than having a list of built-in drivers in > that we'll now defer probe twice before giving up. This shouldn't have a > significant impact on boot times as past discussions about deferred > probe have given no evidence of deferred probe having a substantial > impact. > > Cc: Will Deacon > Cc: Robin Murphy > Cc: Joerg Roedel > Cc: Marek Szyprowski > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Rob Clark > Cc: Heiko Stuebner > Cc: Frank Rowand > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Signed-off-by: Rob Herring > --- > drivers/iommu/arm-smmu-v3.c | 2 -- > drivers/iommu/arm-smmu.c | 7 ------- > drivers/iommu/exynos-iommu.c | 2 -- > drivers/iommu/ipmmu-vmsa.c | 3 --- > drivers/iommu/msm_iommu.c | 2 -- > drivers/iommu/of_iommu.c | 19 +------------------ > drivers/iommu/qcom_iommu.c | 2 -- > drivers/iommu/rockchip-iommu.c | 2 -- > include/linux/of_iommu.h | 4 ---- > 9 files changed, 1 insertion(+), 42 deletions(-) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 1d647104bccc..22bdabd3d8e0 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -2915,8 +2915,6 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3"); > - > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMUv3 implementations"); > MODULE_AUTHOR("Will Deacon "); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 69e7c60792a8..9dd7cbaa3b0c 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2211,13 +2211,6 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1"); > -IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2"); > -IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400"); > -IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401"); > -IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500"); > -IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2"); > - > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations"); > MODULE_AUTHOR("Will Deacon "); > MODULE_LICENSE("GPL v2"); For the SMMU drivers: Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Fri, 25 May 2018 12:31:05 +0100 Subject: [PATCH v2 7/8] iommu: Remove IOMMU_OF_DECLARE In-Reply-To: <20180524175024.19874-8-robh@kernel.org> References: <20180524175024.19874-1-robh@kernel.org> <20180524175024.19874-8-robh@kernel.org> Message-ID: <20180525113104.GA3255@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 24, 2018 at 12:50:23PM -0500, Rob Herring wrote: > Now that we use the driver core to stop deferred probe for missing > drivers, IOMMU_OF_DECLARE can be removed. > > This is slightly less optimal than having a list of built-in drivers in > that we'll now defer probe twice before giving up. This shouldn't have a > significant impact on boot times as past discussions about deferred > probe have given no evidence of deferred probe having a substantial > impact. > > Cc: Will Deacon > Cc: Robin Murphy > Cc: Joerg Roedel > Cc: Marek Szyprowski > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Rob Clark > Cc: Heiko Stuebner > Cc: Frank Rowand > Cc: linux-arm-kernel at lists.infradead.org > Cc: iommu at lists.linux-foundation.org > Cc: linux-samsung-soc at vger.kernel.org > Cc: linux-arm-msm at vger.kernel.org > Cc: linux-rockchip at lists.infradead.org > Cc: devicetree at vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/iommu/arm-smmu-v3.c | 2 -- > drivers/iommu/arm-smmu.c | 7 ------- > drivers/iommu/exynos-iommu.c | 2 -- > drivers/iommu/ipmmu-vmsa.c | 3 --- > drivers/iommu/msm_iommu.c | 2 -- > drivers/iommu/of_iommu.c | 19 +------------------ > drivers/iommu/qcom_iommu.c | 2 -- > drivers/iommu/rockchip-iommu.c | 2 -- > include/linux/of_iommu.h | 4 ---- > 9 files changed, 1 insertion(+), 42 deletions(-) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 1d647104bccc..22bdabd3d8e0 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -2915,8 +2915,6 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3"); > - > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMUv3 implementations"); > MODULE_AUTHOR("Will Deacon "); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 69e7c60792a8..9dd7cbaa3b0c 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2211,13 +2211,6 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1"); > -IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2"); > -IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400"); > -IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401"); > -IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500"); > -IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2"); > - > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations"); > MODULE_AUTHOR("Will Deacon "); > MODULE_LICENSE("GPL v2"); For the SMMU drivers: Acked-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966407AbeEYLaj (ORCPT ); Fri, 25 May 2018 07:30:39 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:60302 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965907AbeEYLah (ORCPT ); Fri, 25 May 2018 07:30:37 -0400 Date: Fri, 25 May 2018 12:31:05 +0100 From: Will Deacon To: Rob Herring Cc: Greg Kroah-Hartman , Linus Walleij , Alexander Graf , Bjorn Andersson , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Joerg Roedel , Robin Murphy , Mark Brown , Frank Rowand , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, boot-architecture@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski , Kukjin Kim , Krzysztof Kozlowski , Rob Clark , Heiko Stuebner , iommu@lists.linux-foundation.org, linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 7/8] iommu: Remove IOMMU_OF_DECLARE Message-ID: <20180525113104.GA3255@arm.com> References: <20180524175024.19874-1-robh@kernel.org> <20180524175024.19874-8-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180524175024.19874-8-robh@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 24, 2018 at 12:50:23PM -0500, Rob Herring wrote: > Now that we use the driver core to stop deferred probe for missing > drivers, IOMMU_OF_DECLARE can be removed. > > This is slightly less optimal than having a list of built-in drivers in > that we'll now defer probe twice before giving up. This shouldn't have a > significant impact on boot times as past discussions about deferred > probe have given no evidence of deferred probe having a substantial > impact. > > Cc: Will Deacon > Cc: Robin Murphy > Cc: Joerg Roedel > Cc: Marek Szyprowski > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Rob Clark > Cc: Heiko Stuebner > Cc: Frank Rowand > Cc: linux-arm-kernel@lists.infradead.org > Cc: iommu@lists.linux-foundation.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-rockchip@lists.infradead.org > Cc: devicetree@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/iommu/arm-smmu-v3.c | 2 -- > drivers/iommu/arm-smmu.c | 7 ------- > drivers/iommu/exynos-iommu.c | 2 -- > drivers/iommu/ipmmu-vmsa.c | 3 --- > drivers/iommu/msm_iommu.c | 2 -- > drivers/iommu/of_iommu.c | 19 +------------------ > drivers/iommu/qcom_iommu.c | 2 -- > drivers/iommu/rockchip-iommu.c | 2 -- > include/linux/of_iommu.h | 4 ---- > 9 files changed, 1 insertion(+), 42 deletions(-) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 1d647104bccc..22bdabd3d8e0 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -2915,8 +2915,6 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv3, "arm,smmu-v3"); > - > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMUv3 implementations"); > MODULE_AUTHOR("Will Deacon "); > MODULE_LICENSE("GPL v2"); > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 69e7c60792a8..9dd7cbaa3b0c 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2211,13 +2211,6 @@ static struct platform_driver arm_smmu_driver = { > }; > module_platform_driver(arm_smmu_driver); > > -IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1"); > -IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2"); > -IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400"); > -IOMMU_OF_DECLARE(arm_mmu401, "arm,mmu-401"); > -IOMMU_OF_DECLARE(arm_mmu500, "arm,mmu-500"); > -IOMMU_OF_DECLARE(cavium_smmuv2, "cavium,smmu-v2"); > - > MODULE_DESCRIPTION("IOMMU API for ARM architected SMMU implementations"); > MODULE_AUTHOR("Will Deacon "); > MODULE_LICENSE("GPL v2"); For the SMMU drivers: Acked-by: Will Deacon Will