From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:37566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752300AbeEZNYG (ORCPT ); Sat, 26 May 2018 09:24:06 -0400 Date: Sat, 26 May 2018 15:23:47 +0200 From: Greg KH To: Daniel Sangorrin Cc: stable@vger.kernel.org, bfoster@redhat.com, darrick.wong@oracle.com, ben.hutchings@codethink.co.uk Subject: Re: Please apply this XFS patch on 4.4 Message-ID: <20180526132347.GC16378@kroah.com> References: <008901d3f3f2$1d6e00e0$584a02a0$@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <008901d3f3f2$1d6e00e0$584a02a0$@toshiba.co.jp> Sender: stable-owner@vger.kernel.org List-ID: On Fri, May 25, 2018 at 03:32:12PM +0900, Daniel Sangorrin wrote: > Subject of the patch: xfs: remove racy hasattr check from attr ops > Commit ID: 5a93790d4e2df73e30c965ec6e49be82fc3ccfce > Why: It didn't pass LTP getxattr04 test, which is "a regression test for the race between getting an existing xattr and setting/removing a large xattr. This bug leads to that getxattr() fails to get an existing xattr and returns ENOATTR in xfs filesystem." > > LTP test getxattr04 was FAILing with this error message: > tst_device.c:230: INFO: Using test device LTP_DEV='/dev/loop0' > tst_mkfs.c:83: INFO: Formatting /dev/loop0 with xfs opts='' extra opts='' > tst_test.c:982: INFO: Timeout per run is 0h 05m 00s > getxattr04.c:72: FAIL: getxattr() failed to get an existing attribute > > After patching 4.4.y and running the test again (on x86_64) it PASSes: > tst_device.c:230: INFO: Using test device LTP_DEV='/dev/loop0' > tst_mkfs.c:83: INFO: Formatting /dev/loop0 with xfs opts='' extra opts='' > tst_test.c:982: INFO: Timeout per run is 0h 05m 00s > getxattr04.c:82: PASS: getxattr() succeeded to get an existing attribute > > What kernel version: 4.4.y (Note: 4.9.y already has it applied) Now applied, thanks. greg k-h