From: Ramon Fried <ramon.fried@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] common: iotrace: add timestamp to iotrace records
Date: Mon, 28 May 2018 14:03:35 +0300 [thread overview]
Message-ID: <20180528110338.19783-4-ramon.fried@gmail.com> (raw)
In-Reply-To: <20180528110338.19783-1-ramon.fried@gmail.com>
Add timestamp to each iotrace record to aid in debugging
of IO timing access bugs.
Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
common/iotrace.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/common/iotrace.c b/common/iotrace.c
index f39885663a3..2f03a6082e8 100644
--- a/common/iotrace.c
+++ b/common/iotrace.c
@@ -27,11 +27,13 @@ enum iotrace_flags {
* struct iotrace_record - Holds a single I/O trace record
*
* @flags: I/O access type
+ * @timestamp: Timestamp of access
* @addr: Address of access
* @value: Value written or read
*/
struct iotrace_record {
enum iotrace_flags flags;
+ u64 timestamp;
phys_addr_t addr;
iovalue_t value;
};
@@ -81,7 +83,7 @@ static void add_record(int flags, const void *ptr, ulong value)
iotrace.start + iotrace.offset,
sizeof(value));
}
-
+ rec->timestamp = timer_get_us();
rec->flags = flags;
rec->addr = map_to_sysmem(ptr);
rec->value = value;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-05-28 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 11:03 [U-Boot] [PATCH v3 0/6] Iotrace improvements Ramon Fried
2018-05-28 11:03 ` [U-Boot] [PATCH 1/6] cmd: iotrace: add set region command Ramon Fried
2018-05-28 11:03 ` [U-Boot] [PATCH 2/6] iotrace: add IO region limit Ramon Fried
2018-05-28 11:03 ` Ramon Fried [this message]
2018-05-28 11:03 ` [U-Boot] [PATCH 4/6] iotrace: move record definitons to header file Ramon Fried
2018-05-28 11:03 ` [U-Boot] [PATCH v2 5/6] cmd: iotrace: add dump trace command Ramon Fried
2018-05-28 11:03 ` [U-Boot] [PATCH v2 6/6] iotrace: fix behaviour when buffer is full Ramon Fried
2018-05-30 19:18 ` [U-Boot] [PATCH v3 0/6] Iotrace improvements Simon Glass
2018-05-30 19:23 ` Ramon Fried
-- strict thread matches above, loose matches on Subject: below --
2018-05-25 10:41 [U-Boot] [PATCH v2 " Ramon Fried
2018-05-25 10:41 ` [U-Boot] [PATCH 3/6] common: iotrace: add timestamp to iotrace records Ramon Fried
2018-05-26 2:07 ` Simon Glass
2018-05-26 6:00 ` Ramon Fried
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528110338.19783-4-ramon.fried@gmail.com \
--to=ramon.fried@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.