From: Igor Mammedov <imammedo@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
pkrempa@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP
Date: Mon, 28 May 2018 11:40:45 +0200 [thread overview]
Message-ID: <20180528114045.7a0e339d@redhat.com> (raw)
In-Reply-To: <87tvqx12no.fsf@dusky.pond.sub.org>
On Thu, 24 May 2018 17:42:03 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> Eduardo Habkost <ehabkost@redhat.com> writes:
>
> > I'm queueing this version (including v8 of patches 5-7) on
> > numa-next.
> >
> > Markus, Daniel: you were the people I remember expressing some
> > concerns about the new preconfig mechanism. Do you have any
> > objections to this version?
>
> My gut's reaction to preconfig is as nauseous as ever. It adds
> complexity we wouldn't want or need with sanely structured program
> startup. It might still be the best we can do, and something we need to
> do. You have to take on technical debt sometimes. To know for sure
> this is the case here, we'd have to explore alternatives more seriously.
> Like repaying some of the existing technical debt around there. Sadly,
> I lack the time to take on such a project.
Usually I do quite a bit of re-factoring to reduce our technical debt,
so while working on enabling VM start with libvirt using only --preconfig
(without -S) I most likely will have to improve code around VM creation.
[...]
next prev parent reply other threads:[~2018-05-28 9:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 8:37 [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP Igor Mammedov
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 01/11] numa: postpone options post-processing till machine_run_board_init() Igor Mammedov
2018-05-16 18:12 ` Eduardo Habkost
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 02/11] numa: split out NumaOptions parsing into set_numa_options() Igor Mammedov
2018-05-16 18:12 ` Eduardo Habkost
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 03/11] qapi: introduce preconfig runstate Igor Mammedov
2018-05-11 15:17 ` Eric Blake
2018-05-16 18:14 ` Eduardo Habkost
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 04/11] hmp: disable monitor in preconfig state Igor Mammedov
2018-05-24 16:00 ` Markus Armbruster
2018-05-24 18:16 ` Markus Armbruster
2018-05-24 18:26 ` Eduardo Habkost
2018-05-25 6:05 ` Markus Armbruster
2018-05-25 19:39 ` Eduardo Habkost
2018-05-28 9:31 ` Igor Mammedov
2018-06-01 8:59 ` Dr. David Alan Gilbert
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 05/11] qapi: introduce new cmd option "allowed-in-preconfig" Igor Mammedov
2018-05-11 15:26 ` Eric Blake
2018-05-11 16:56 ` Igor Mammedov
2018-05-11 16:51 ` [Qemu-devel] [PATCH v8 05/11] qapi: introduce new cmd option "allow-preconfig" Igor Mammedov
2018-05-11 17:16 ` Eric Blake
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 06/11] tests: qapi-schema tests for allow-preconfig Igor Mammedov
2018-05-11 15:29 ` Eric Blake
2018-05-16 18:16 ` Eduardo Habkost
2018-05-11 17:15 ` [Qemu-devel] [PATCH v8 " Igor Mammedov
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 07/11] cli: add --preconfig option Igor Mammedov
2018-05-11 15:36 ` Eric Blake
2018-05-11 17:24 ` [Qemu-devel] [PATCH v8 " Igor Mammedov
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 08/11] tests: extend qmp test with preconfig checks Igor Mammedov
2018-05-16 18:20 ` Eduardo Habkost
2018-05-16 22:21 ` Eric Blake
2018-05-17 11:28 ` [Qemu-devel] [PATCH v8 " Igor Mammedov
2018-05-17 13:43 ` Eric Blake
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 09/11] qmp: permit query-hotpluggable-cpus in preconfig state Igor Mammedov
2018-05-16 18:24 ` Eduardo Habkost
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 10/11] qmp: add set-numa-node command Igor Mammedov
2018-05-16 18:26 ` Eduardo Habkost
2018-05-04 8:37 ` [Qemu-devel] [PATCH v7 11/11] tests: functional tests for QMP command set-numa-node Igor Mammedov
2018-05-16 18:27 ` Eduardo Habkost
2018-05-16 22:12 ` Eduardo Habkost
2018-05-17 8:01 ` Igor Mammedov
2018-05-17 11:27 ` Igor Mammedov
2018-05-17 11:30 ` [Qemu-devel] [PATCH v8 " Igor Mammedov
2018-05-16 19:02 ` [Qemu-devel] [PATCH v7 00/11] enable numa configuration before machine_init() from QMP Eduardo Habkost
2018-05-24 15:42 ` Markus Armbruster
2018-05-28 9:40 ` Igor Mammedov [this message]
2018-05-30 10:47 ` Igor Mammedov
2018-05-30 16:22 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528114045.7a0e339d@redhat.com \
--to=imammedo@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.