From: Christian Brauner <christian@brauner.io>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, ebiederm@xmission.com,
gregkh@linuxfoundation.org, mingo@kernel.org,
james.morris@microsoft.com, keescook@chromium.org,
peterz@infradead.org, sds@tycho.nsa.gov,
akpm@linux-foundation.org, oleg@redhat.com
Subject: Re: [PATCH 5/8] signal: flatten do_send_sig_info()
Date: Mon, 28 May 2018 17:07:20 +0200 [thread overview]
Message-ID: <20180528150719.GA29882@mailbox.org> (raw)
In-Reply-To: <20180528141537.GA30522@ZenIV.linux.org.uk>
On Mon, May 28, 2018 at 03:15:37PM +0100, Al Viro wrote:
> On Mon, May 28, 2018 at 03:49:13PM +0200, Christian Brauner wrote:
> > Let's return early when lock_task_sighand() fails and move send_signal()
> > and unlock_task_sighand() out of the if block.
>
> Why is it an improvement?
I prefer to return early if I know I can and have the bigger portion of
the code move out of the if-branch. But that's - let's say - an
opinionated improvement.
Christian
next prev parent reply other threads:[~2018-05-28 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 13:49 [PATCH 0/8] signal: refactor some functions Christian Brauner
2018-05-28 13:49 ` [PATCH 1/8] signal: make force_sigsegv() void Christian Brauner
2018-05-28 13:49 ` [PATCH 2/8] signal: make kill_as_cred_perm() return bool Christian Brauner
2018-05-28 14:07 ` Al Viro
2018-05-28 18:31 ` Christian Brauner
2018-05-28 13:49 ` [PATCH 3/8] signal: make may_ptrace_stop() " Christian Brauner
2018-05-28 14:12 ` Al Viro
2018-05-28 18:30 ` Christian Brauner
2018-05-28 13:49 ` [PATCH 4/8] signal: add copy_pending() helper Christian Brauner
2018-05-28 13:49 ` [PATCH 5/8] signal: flatten do_send_sig_info() Christian Brauner
2018-05-28 14:15 ` Al Viro
2018-05-28 15:07 ` Christian Brauner [this message]
2018-05-28 13:49 ` [PATCH 6/8] signal: drop else branch in do_signal_stop() Christian Brauner
2018-05-28 13:49 ` [PATCH 7/8] signal: make do_sigpending() void Christian Brauner
2018-05-28 14:20 ` Al Viro
2018-05-28 13:49 ` [PATCH 8/8] signal: simplify rt_sigaction() Christian Brauner
2018-05-29 6:47 ` Christoph Hellwig
2018-05-29 10:24 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528150719.GA29882@mailbox.org \
--to=christian@brauner.io \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morris@microsoft.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=sds@tycho.nsa.gov \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.