From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused Date: Mon, 28 May 2018 16:32:43 +0200 Message-ID: <20180528163243.538de32f@bbrezillon> References: <20180525155030.3667352-1-arnd@arndb.de> <20180525155030.3667352-8-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 731D36E191 for ; Mon, 28 May 2018 14:32:55 +0000 (UTC) In-Reply-To: <20180525155030.3667352-8-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Arnd Bergmann Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org K1RoaWVycnkKCkhpIEFybmQsCgpPbiBGcmksIDI1IE1heSAyMDE4IDE3OjUwOjE1ICswMjAwCkFy bmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+IHdyb3RlOgoKPiBUaGVzZSB0d28gZnVuY3Rpb25z IGFyZSB1bnVzZWQgaW4gc29tZSBjb25maWd1cmF0aW9ucywgYW5kIHVzaW5nIF9fbWF5YmVfdW51 c2VkCj4gaXMgdGhlIGVhc2llc3Qgd2F5IHRvIHNodXQgdXAgdGhlIGhhcm1sZXNzIHdhcm5pbmdz Ogo+IAo+IGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvY2Rucy1kc2kuYzoxMzUzOjEyOiBlcnJvcjog J2NkbnNfZHNpX3N1c3BlbmQnIGRlZmluZWQgYnV0IG5vdCB1c2VkIFstV2Vycm9yPXVudXNlZC1m dW5jdGlvbl0KPiAgc3RhdGljIGludCBjZG5zX2RzaV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRl dikKPiAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+Cj4gZHJpdmVycy9ncHUvZHJtL2JyaWRn ZS9jZG5zLWRzaS5jOjEzNDA6MTI6IGVycm9yOiAnY2Ruc19kc2lfcmVzdW1lJyBkZWZpbmVkIGJ1 dCBub3QgdXNlZCBbLVdlcnJvcj11bnVzZWQtZnVuY3Rpb25dCj4gIHN0YXRpYyBpbnQgY2Ruc19k c2lfcmVzdW1lKHN0cnVjdCBkZXZpY2UgKmRldikKPiAKPiBGaXhlczogZTE5MjMzOTU1ZDllICgi ZHJtL2JyaWRnZTogQWRkIENhZGVuY2UgRFNJIGRyaXZlciIpCj4gU2lnbmVkLW9mZi1ieTogQXJu ZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4KCkhtLCBJIHRob3VnaHQgc3VjaCBhIHBhdGNoIGhh ZCBhbHJlYWR5IGJlZW4gYXBwbGllZCBieSBUaGllcnJ5IFsxXS4KClsxXWh0dHBzOi8vd3d3LnNw aW5pY3MubmV0L2xpc3RzL2RyaS1kZXZlbC9tc2cxNzQzNjMuaHRtbAoKPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9jZG5zLWRzaS5jIHwgNCArKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAy IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9icmlkZ2UvY2Rucy1kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvY2Rucy1k c2kuYwo+IGluZGV4IGMyNTVmYzNlMWJlNS4uZjJkNDNmMjRhY2ZiIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9icmlkZ2UvY2Rucy1kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9i cmlkZ2UvY2Rucy1kc2kuYwo+IEBAIC0xMzM3LDcgKzEzMzcsNyBAQCBzdGF0aWMgY29uc3Qgc3Ry dWN0IG1pcGlfZHNpX2hvc3Rfb3BzIGNkbnNfZHNpX29wcyA9IHsKPiAgCS50cmFuc2ZlciA9IGNk bnNfZHNpX3RyYW5zZmVyLAo+ICB9Owo+ICAKPiAtc3RhdGljIGludCBjZG5zX2RzaV9yZXN1bWUo c3RydWN0IGRldmljZSAqZGV2KQo+ICtzdGF0aWMgaW50IF9fbWF5YmVfdW51c2VkIGNkbnNfZHNp X3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0cnVjdCBjZG5zX2RzaSAqZHNp ID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gIAo+IEBAIC0xMzUwLDcgKzEzNTAsNyBAQCBzdGF0 aWMgaW50IGNkbnNfZHNpX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAlyZXR1cm4gMDsK PiAgfQo+ICAKPiAtc3RhdGljIGludCBjZG5zX2RzaV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRl dikKPiArc3RhdGljIGludCBfX21heWJlX3VudXNlZCBjZG5zX2RzaV9zdXNwZW5kKHN0cnVjdCBk ZXZpY2UgKmRldikKPiAgewo+ICAJc3RydWN0IGNkbnNfZHNpICpkc2kgPSBkZXZfZ2V0X2RydmRh dGEoZGV2KTsKPiAgCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165760AbeE1Oc7 (ORCPT ); Mon, 28 May 2018 10:32:59 -0400 Received: from mail.bootlin.com ([62.4.15.54]:54638 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161676AbeE1Ocz (ORCPT ); Mon, 28 May 2018 10:32:55 -0400 Date: Mon, 28 May 2018 16:32:43 +0200 From: Boris Brezillon To: Arnd Bergmann Cc: Archit Taneja , Andrzej Hajda , David Airlie , Laurent Pinchart , Eric Anholt , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding Subject: Re: [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused Message-ID: <20180528163243.538de32f@bbrezillon> In-Reply-To: <20180525155030.3667352-8-arnd@arndb.de> References: <20180525155030.3667352-1-arnd@arndb.de> <20180525155030.3667352-8-arnd@arndb.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Thierry Hi Arnd, On Fri, 25 May 2018 17:50:15 +0200 Arnd Bergmann wrote: > These two functions are unused in some configurations, and using __maybe_unused > is the easiest way to shut up the harmless warnings: > > drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error: 'cdns_dsi_suspend' defined but not used [-Werror=unused-function] > static int cdns_dsi_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~ > drivers/gpu/drm/bridge/cdns-dsi.c:1340:12: error: 'cdns_dsi_resume' defined but not used [-Werror=unused-function] > static int cdns_dsi_resume(struct device *dev) > > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") > Signed-off-by: Arnd Bergmann Hm, I thought such a patch had already been applied by Thierry [1]. [1]https://www.spinics.net/lists/dri-devel/msg174363.html > --- > drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c > index c255fc3e1be5..f2d43f24acfb 100644 > --- a/drivers/gpu/drm/bridge/cdns-dsi.c > +++ b/drivers/gpu/drm/bridge/cdns-dsi.c > @@ -1337,7 +1337,7 @@ static const struct mipi_dsi_host_ops cdns_dsi_ops = { > .transfer = cdns_dsi_transfer, > }; > > -static int cdns_dsi_resume(struct device *dev) > +static int __maybe_unused cdns_dsi_resume(struct device *dev) > { > struct cdns_dsi *dsi = dev_get_drvdata(dev); > > @@ -1350,7 +1350,7 @@ static int cdns_dsi_resume(struct device *dev) > return 0; > } > > -static int cdns_dsi_suspend(struct device *dev) > +static int __maybe_unused cdns_dsi_suspend(struct device *dev) > { > struct cdns_dsi *dsi = dev_get_drvdata(dev); >