From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Prarit Bhargava <prarit@redhat.com>
Cc: Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
X86 ML <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rik van Riel <riel@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Kate Stewart <kstewart@linuxfoundation.org>
Subject: Re: [PATCH] x86, random: Fix get_random_bytes() warning in x86 start_kernel
Date: Tue, 29 May 2018 12:07:43 -0400 [thread overview]
Message-ID: <20180529160743.GA7381@thunk.org> (raw)
In-Reply-To: <71b5df93-2e21-f3c3-fa22-4488729daeb5@redhat.com>
On Tue, May 29, 2018 at 11:01:07AM -0400, Prarit Bhargava wrote:
> Kees, in early boot no pool is available so the stack canary is initialized from
> the TSC. Later in boot, the stack canary will use the the crng.
>
> ie) in early boot only TSC is okay, and late boot (when crng_ready() is true)
> the pool will be used.
But that means all of the kernel threads (e.g., workqueues, et. al)
would not be well protected by the stack canary. That
seems.... rather unfortunate.
- Ted
next prev parent reply other threads:[~2018-05-29 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 12:38 [PATCH] x86, random: Fix get_random_bytes() warning in x86 start_kernel Prarit Bhargava
2018-05-29 14:49 ` Kees Cook
2018-05-29 15:01 ` Prarit Bhargava
2018-05-29 16:07 ` Theodore Y. Ts'o [this message]
2018-05-29 16:58 ` Prarit Bhargava
2018-05-29 18:19 ` hpa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529160743.GA7381@thunk.org \
--to=tytso@mit.edu \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pombredanne@nexb.com \
--cc=prarit@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.