From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] Make ./new work for non-root user
Date: Wed, 30 May 2018 08:00:03 +1000 [thread overview]
Message-ID: <20180529220003.GP10363@dastard> (raw)
In-Reply-To: <20180529165119.31961-2-jack@suse.cz>
On Tue, May 29, 2018 at 06:51:19PM +0200, Jan Kara wrote:
> Currently 'new' script sources common/config which tries to find mkfs
> and fails if not found (which is likely for non-root user). This is
> inconvenient as development usually does not happen as root. In fact the
> vast majority of setup in common/config and common/rc is not necessary
> for 'new'. Split out the necessary bits into new common/config-base and
> use it in 'new'. Cleanup common/rc and common/config now that they're
> only used from 'check' and 'setup'.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Looks good!
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-05-29 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 16:51 [PATCH 1/2] fstests: get rid of set_prog_path Jan Kara
2018-05-29 16:51 ` [PATCH 2/2] Make ./new work for non-root user Jan Kara
2018-05-29 22:00 ` Dave Chinner [this message]
2018-06-03 14:21 ` [PATCH 1/2] fstests: get rid of set_prog_path Eryu Guan
2018-06-06 8:55 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529220003.GP10363@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.