All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ti-sgx-*: bump from SDK 02.00 to SDK 04.00
Date: Tue, 29 May 2018 23:42:43 +0200	[thread overview]
Message-ID: <20180529234243.699648ec@windsurf.home> (raw)
In-Reply-To: <CABhNV22Fv+QjYta+XhH5mixGPK5R0sOnMv=R3+4qpV+iqGegzg@mail.gmail.com>

Hello,

On Mon, 28 May 2018 14:20:44 +0200, Einar J?n wrote:

> > I'm not sure if we must bump all packages related to the TI SDK or bump all
> > packages one by one to ease the review.  
> 
> I did this in a single commit since any split (except a standalone
> ti-sgx-libgbm) would be a commit with a broken build. The places I?ve
> worked for for the last 5 years hate those.

We definitely want a bisectable patch series, where everything works
between each commit.

> > Also, BR2_PACKAGE_TI_SGX_KM_AM4430 and BR2_PACKAGE_TI_SGX_KM_AM5430
> > symbols are
> > removed. It must be handled in Config.in.legacy.  
> 
> 
> True. I didn?t think of that since none of the defconfigs use it. I can see
> that now there is a legacy patch for the _KM addition.
> Also, the new _KM addition to these keywords makes these parameters a bit
> weird, because it is used in both ti-sgx-km and ti-sgx-um.

I don't see where those renamed symbols are used in ti-sgx-um. The
symbols that have been renamed are:

  BR2_PACKAGE_TI_SGX_AM335X
  BR2_PACKAGE_TI_SGX_AM437X
  BR2_PACKAGE_TI_SGX_AM4430
  BR2_PACKAGE_TI_SGX_AM5430

> > Why S80ti-sgx is removed ?
> >  
> 
> Because it is both unneeded and obsolete.
> The current repo of ti-sgx-um has 3 subfolders, one for each
> BR2_PACKAGE_TI_SGX_KM_AMxxx option. Each one has a sysV init file (called
> rc-???) that is very different from the one I deleted.
> Now I simply rename rc-??? to S80ti-sgx in the post-hook that previously
> copied it from package/ti-sgx-um.

Is the init script provided by upstream reasonably compatible with
Buildroot requirements (it should work with Busybox, etc.) ? We very
often have our own init scripts to make sure they are compatible with
Buildroot-generated systems.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-29 21:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 15:24 [Buildroot] [PATCH 1/1] ti-sgx-*: bump from SDK 02.00 to SDK 04.00 Einar Jon Gunnarsson
2018-05-24 15:38 ` Einar Jón
2018-05-27 20:54   ` Romain Naour
2018-05-28 12:20     ` Einar Jón
2018-05-29 21:42       ` Thomas Petazzoni [this message]
     [not found]         ` <CABhNV22Le5eOW9A8LHXS+TJQSishWPS0WPZN2z9r=GkGfMa6xQ@mail.gmail.com>
2018-05-30 14:49           ` Thomas Petazzoni
2018-05-31 20:39             ` Einar Jón
2018-07-06 13:36               ` Einar Jón
2018-07-06 13:49                 ` Thomas Petazzoni
2018-07-14 19:01                   ` Einar Jón

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529234243.699648ec@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.