From: Omar Sandoval <osandov@osandov.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Omar Sandoval <osandov@fb.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block/020: not pass shared_tags to null_blk
Date: Tue, 29 May 2018 22:47:42 -0700 [thread overview]
Message-ID: <20180530054742.GA19332@vader> (raw)
In-Reply-To: <20180530051038.9192-1-ming.lei@redhat.com>
On Wed, May 30, 2018 at 01:10:38PM +0800, Ming Lei wrote:
> The issue isn't related with shared tag, and it can be
> triggered in case 'shared_tags' is set as 0.
>
> Remove this so that this test can be run in older kernel, and
> avoid to cause misunderstanding.
Thanks, Ming, applied.
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> tests/block/020 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/block/020 b/tests/block/020
> index 40a8151c90a8..36140136369b 100755
> --- a/tests/block/020
> +++ b/tests/block/020
> @@ -31,7 +31,7 @@ test() {
>
> modprobe -r null_blk
> modprobe null_blk queue_mode=2 irqmode=2 completion_nsec=2000000 \
> - shared_tags=1 submit_queues=4 hw_queue_depth=1
> + submit_queues=4 hw_queue_depth=1
>
> local scheds
> # shellcheck disable=SC2207
> --
> 2.9.5
>
prev parent reply other threads:[~2018-05-30 5:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 5:10 [PATCH] block/020: not pass shared_tags to null_blk Ming Lei
2018-05-30 5:47 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530054742.GA19332@vader \
--to=osandov@osandov.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.