From: Aaron Lu <aaron.lu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] libata: zpodd: small read overflow in eject_tray()
Date: Wed, 30 May 2018 06:20:39 +0000 [thread overview]
Message-ID: <20180530062038.GE14785@intel.com> (raw)
In-Reply-To: <20180529091320.axeryttqycdexzm5@kili.mountain>
On Tue, May 29, 2018 at 12:13:24PM +0300, Dan Carpenter wrote:
> We read from the cdb[] buffer in ata_exec_internal_sg(). It has to be
> ATAPI_CDB_LEN (16) bytes long, but this buffer is only 12 bytes.
Thanks for the fix!
>
> Fixes: 213342053db5 ("libata: handle power transition of ODD")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/ata/libata-zpodd.c b/drivers/ata/libata-zpodd.c
> index de4ddd0e8550..b3ed8f9953a8 100644
> --- a/drivers/ata/libata-zpodd.c
> +++ b/drivers/ata/libata-zpodd.c
> @@ -35,7 +35,7 @@ struct zpodd {
> static int eject_tray(struct ata_device *dev)
> {
> struct ata_taskfile tf;
> - static const char cdb[] = { GPCMD_START_STOP_UNIT,
> + static const char cdb[ATAPI_CDB_LEN] = { GPCMD_START_STOP_UNIT,
> 0, 0, 0,
> 0x02, /* LoEj */
> 0, 0, 0, 0, 0, 0, 0,
prev parent reply other threads:[~2018-05-30 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 9:13 [PATCH] libata: zpodd: small read overflow in eject_tray() Dan Carpenter
2018-05-29 13:50 ` Tejun Heo
2018-05-30 6:20 ` Aaron Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530062038.GE14785@intel.com \
--to=aaron.lu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.