From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH] PCI: Add pci=safemode option Date: Wed, 30 May 2018 09:48:22 +0200 Message-ID: <20180530074822.GB30177@kroah.com> References: <1527650389-31575-1-git-send-email-okaya@codeaurora.org> <20180530043103.GA19734@kroah.com> <6c317ed8-cca3-8862-5f3b-12cf14e4d53b@codeaurora.org> <20180530073735.GA28793@infradead.org> <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: okaya@codeaurora.org Cc: Christoph Hellwig , linux-pci@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jonathan Corbet , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Christoffer Dall , "Paul E. McKenney" , Marc Zyngier , Kai-Heng Feng , Thymo van Beers , Frederic Weisbecker , Konrad Rzeszutek Wilk , David Rientjes , "Rafael J. Wysocki" , Keith Busch , Dongdong Liu List-Id: linux-arm-msm@vger.kernel.org On Wed, May 30, 2018 at 12:44:29AM -0700, okaya@codeaurora.org wrote: > On 2018-05-30 00:37, Christoph Hellwig wrote: > > On Tue, May 29, 2018 at 09:41:33PM -0700, Sinan Kaya wrote: > > > Bjorn and I discussed the need for such a "safe" mode feature when you > > > want to bring up PCI for a platform. You want to turn off everything > > > as > > > a starter and just stick to bare minimum. > > > > Can we please make it a config option the instead of adding code > > to every kernel? Also maybe the bringup should be in the name > > to make this more clear? > > One other requirement was to have a runtime option rather than compile time > option. > > When someone reported a problem, we wanted to be able to say "use this > option and see if system boots" without doing any bisects or recompilation. > > This would be the first step in troubleshooting a system to see if > fundamental features are working. That makes sense, people can not rebuild their kernels for the most part. Putting it behind a config option would not make sense as it would always have to be enabled. > I don't mind changing the name Bjorn mentioned safe option. I made it > safemode. I am looking at Bjorn for suggestions at this moment. "minimal"? "basic"? "crippled"? "my_hardware_is_so_borked_it_needs_this_option"? :) Naming is hard... greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.6 required=5.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id A0DB97D09D for ; Wed, 30 May 2018 07:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935895AbeE3Hsr (ORCPT ); Wed, 30 May 2018 03:48:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:60814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934903AbeE3Hsq (ORCPT ); Wed, 30 May 2018 03:48:46 -0400 Received: from localhost (unknown [37.173.62.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 449A72087D; Wed, 30 May 2018 07:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527666525; bh=fWQABMSDwJbrrPV/pBW/z7kDvjbNc7sBySBcwfb9OAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KgGx205Y1iAAGnmQ8B6Wsdhtwk5fB1fMthkdzxA389L6xlbQ0XjqMsnIUmeWYvkFa sr6EpuDLbYotae/l5ietpiWfcY0cVsB1ksP0MG1DmWlNVH/YWnSQaP2SS+zHEf6Ger CEral6vABYf9ktXbu1Yy2wlA+yQ9SdppEHsHhTXA= Date: Wed, 30 May 2018 09:48:22 +0200 From: Greg Kroah-Hartman To: okaya@codeaurora.org Cc: Christoph Hellwig , linux-pci@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jonathan Corbet , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Christoffer Dall , "Paul E. McKenney" , Marc Zyngier , Kai-Heng Feng , Thymo van Beers , Frederic Weisbecker , Konrad Rzeszutek Wilk , David Rientjes , "Rafael J. Wysocki" , Keith Busch , Dongdong Liu , Frederick Lawler , Oza Pawandeep , Gabriele Paoloni , "open list:DOCUMENTATION" , open list Subject: Re: [PATCH] PCI: Add pci=safemode option Message-ID: <20180530074822.GB30177@kroah.com> References: <1527650389-31575-1-git-send-email-okaya@codeaurora.org> <20180530043103.GA19734@kroah.com> <6c317ed8-cca3-8862-5f3b-12cf14e4d53b@codeaurora.org> <20180530073735.GA28793@infradead.org> <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, May 30, 2018 at 12:44:29AM -0700, okaya@codeaurora.org wrote: > On 2018-05-30 00:37, Christoph Hellwig wrote: > > On Tue, May 29, 2018 at 09:41:33PM -0700, Sinan Kaya wrote: > > > Bjorn and I discussed the need for such a "safe" mode feature when you > > > want to bring up PCI for a platform. You want to turn off everything > > > as > > > a starter and just stick to bare minimum. > > > > Can we please make it a config option the instead of adding code > > to every kernel? Also maybe the bringup should be in the name > > to make this more clear? > > One other requirement was to have a runtime option rather than compile time > option. > > When someone reported a problem, we wanted to be able to say "use this > option and see if system boots" without doing any bisects or recompilation. > > This would be the first step in troubleshooting a system to see if > fundamental features are working. That makes sense, people can not rebuild their kernels for the most part. Putting it behind a config option would not make sense as it would always have to be enabled. > I don't mind changing the name Bjorn mentioned safe option. I made it > safemode. I am looking at Bjorn for suggestions at this moment. "minimal"? "basic"? "crippled"? "my_hardware_is_so_borked_it_needs_this_option"? :) Naming is hard... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Date: Wed, 30 May 2018 09:48:22 +0200 From: Greg Kroah-Hartman To: okaya@codeaurora.org Subject: Re: [PATCH] PCI: Add pci=safemode option Message-ID: <20180530074822.GB30177@kroah.com> References: <1527650389-31575-1-git-send-email-okaya@codeaurora.org> <20180530043103.GA19734@kroah.com> <6c317ed8-cca3-8862-5f3b-12cf14e4d53b@codeaurora.org> <20180530073735.GA28793@infradead.org> <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> MIME-Version: 1.0 In-Reply-To: <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gabriele Paoloni , "open list:DOCUMENTATION" , linux-pci@vger.kernel.org, Keith Busch , Kai-Heng Feng , Ingo Molnar , Christoffer Dall , Jonathan Corbet , timur@codeaurora.org, "Rafael J. Wysocki" , Christoph Hellwig , Dongdong Liu , David Rientjes , Thymo van Beers , "Paul E. McKenney" , Frederick Lawler , Konrad Rzeszutek Wilk , Marc Zyngier , linux-arm-msm@vger.kernel.org, Frederic Weisbecker , Bjorn Helgaas , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Oza Pawandeep , open list Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: On Wed, May 30, 2018 at 12:44:29AM -0700, okaya@codeaurora.org wrote: > On 2018-05-30 00:37, Christoph Hellwig wrote: > > On Tue, May 29, 2018 at 09:41:33PM -0700, Sinan Kaya wrote: > > > Bjorn and I discussed the need for such a "safe" mode feature when you > > > want to bring up PCI for a platform. You want to turn off everything > > > as > > > a starter and just stick to bare minimum. > > > > Can we please make it a config option the instead of adding code > > to every kernel? Also maybe the bringup should be in the name > > to make this more clear? > > One other requirement was to have a runtime option rather than compile time > option. > > When someone reported a problem, we wanted to be able to say "use this > option and see if system boots" without doing any bisects or recompilation. > > This would be the first step in troubleshooting a system to see if > fundamental features are working. That makes sense, people can not rebuild their kernels for the most part. Putting it behind a config option would not make sense as it would always have to be enabled. > I don't mind changing the name Bjorn mentioned safe option. I made it > safemode. I am looking at Bjorn for suggestions at this moment. "minimal"? "basic"? "crippled"? "my_hardware_is_so_borked_it_needs_this_option"? :) Naming is hard... greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Wed, 30 May 2018 09:48:22 +0200 Subject: [PATCH] PCI: Add pci=safemode option In-Reply-To: <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> References: <1527650389-31575-1-git-send-email-okaya@codeaurora.org> <20180530043103.GA19734@kroah.com> <6c317ed8-cca3-8862-5f3b-12cf14e4d53b@codeaurora.org> <20180530073735.GA28793@infradead.org> <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> Message-ID: <20180530074822.GB30177@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 30, 2018 at 12:44:29AM -0700, okaya at codeaurora.org wrote: > On 2018-05-30 00:37, Christoph Hellwig wrote: > > On Tue, May 29, 2018 at 09:41:33PM -0700, Sinan Kaya wrote: > > > Bjorn and I discussed the need for such a "safe" mode feature when you > > > want to bring up PCI for a platform. You want to turn off everything > > > as > > > a starter and just stick to bare minimum. > > > > Can we please make it a config option the instead of adding code > > to every kernel? Also maybe the bringup should be in the name > > to make this more clear? > > One other requirement was to have a runtime option rather than compile time > option. > > When someone reported a problem, we wanted to be able to say "use this > option and see if system boots" without doing any bisects or recompilation. > > This would be the first step in troubleshooting a system to see if > fundamental features are working. That makes sense, people can not rebuild their kernels for the most part. Putting it behind a config option would not make sense as it would always have to be enabled. > I don't mind changing the name Bjorn mentioned safe option. I made it > safemode. I am looking at Bjorn for suggestions at this moment. "minimal"? "basic"? "crippled"? "my_hardware_is_so_borked_it_needs_this_option"? :) Naming is hard... greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937208AbeE3Hss (ORCPT ); Wed, 30 May 2018 03:48:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:60814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934903AbeE3Hsq (ORCPT ); Wed, 30 May 2018 03:48:46 -0400 Date: Wed, 30 May 2018 09:48:22 +0200 From: Greg Kroah-Hartman To: okaya@codeaurora.org Cc: Christoph Hellwig , linux-pci@vger.kernel.org, timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jonathan Corbet , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Christoffer Dall , "Paul E. McKenney" , Marc Zyngier , Kai-Heng Feng , Thymo van Beers , Frederic Weisbecker , Konrad Rzeszutek Wilk , David Rientjes , "Rafael J. Wysocki" , Keith Busch , Dongdong Liu , Frederick Lawler , Oza Pawandeep , Gabriele Paoloni , "open list:DOCUMENTATION" , open list Subject: Re: [PATCH] PCI: Add pci=safemode option Message-ID: <20180530074822.GB30177@kroah.com> References: <1527650389-31575-1-git-send-email-okaya@codeaurora.org> <20180530043103.GA19734@kroah.com> <6c317ed8-cca3-8862-5f3b-12cf14e4d53b@codeaurora.org> <20180530073735.GA28793@infradead.org> <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6dfe2db8f974d94c9867f30ec83d9333@codeaurora.org> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 12:44:29AM -0700, okaya@codeaurora.org wrote: > On 2018-05-30 00:37, Christoph Hellwig wrote: > > On Tue, May 29, 2018 at 09:41:33PM -0700, Sinan Kaya wrote: > > > Bjorn and I discussed the need for such a "safe" mode feature when you > > > want to bring up PCI for a platform. You want to turn off everything > > > as > > > a starter and just stick to bare minimum. > > > > Can we please make it a config option the instead of adding code > > to every kernel? Also maybe the bringup should be in the name > > to make this more clear? > > One other requirement was to have a runtime option rather than compile time > option. > > When someone reported a problem, we wanted to be able to say "use this > option and see if system boots" without doing any bisects or recompilation. > > This would be the first step in troubleshooting a system to see if > fundamental features are working. That makes sense, people can not rebuild their kernels for the most part. Putting it behind a config option would not make sense as it would always have to be enabled. > I don't mind changing the name Bjorn mentioned safe option. I made it > safemode. I am looking at Bjorn for suggestions at this moment. "minimal"? "basic"? "crippled"? "my_hardware_is_so_borked_it_needs_this_option"? :) Naming is hard... greg k-h