From: Segher Boessenkool <segher@kernel.crashing.org>
To: Simon Guo <wei.guo.simon@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Cyril Bur <cyrilbur@gmail.com>
Subject: Re: [PATCH v6 1/4] powerpc/64: Align bytes before fall back to .Lshort in powerpc64 memcmp()
Date: Wed, 30 May 2018 03:27:39 -0500 [thread overview]
Message-ID: <20180530082739.GF17342@gate.crashing.org> (raw)
In-Reply-To: <20180530081150.GA5951@simonLocalRHEL7.x64>
Hi!
On Wed, May 30, 2018 at 04:11:50PM +0800, Simon Guo wrote:
> On Mon, May 28, 2018 at 05:35:12AM -0500, Segher Boessenkool wrote:
> > On Fri, May 25, 2018 at 12:07:33PM +0800, wei.guo.simon@gmail.com wrote:
> > If this doesn't use cr0 anymore, you can do rlwinm r6,r6,0,7 instead of
> > andi r6,r6,7 .
> >
> CR0 is used at .Lno_short handling.
Tricky.
> > > + subfc. r5,r6,r5
> >
> > Why subfc? You don't use the carry.
> OK. I will use subfc instead.
I meant subf -- no carry. If you want CR0 set there is subf. just fine.
> > > + bgt cr0,8f
> > > + li r3,-1
> > > +8:
> > > + blr
> >
> > blelr
> > li r3,-1
> > blr
> Sure. That looks more impact.
Should have been bgtlr of course -- well check please :-)
Segher
next prev parent reply other threads:[~2018-05-30 8:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 4:07 [PATCH v6 0/4] powerpc/64: memcmp() optimization wei.guo.simon
2018-05-25 4:07 ` [PATCH v6 1/4] powerpc/64: Align bytes before fall back to .Lshort in powerpc64 memcmp() wei.guo.simon
2018-05-28 10:35 ` Segher Boessenkool
2018-05-30 8:11 ` Simon Guo
2018-05-30 8:27 ` Segher Boessenkool [this message]
2018-05-30 9:02 ` Simon Guo
2018-05-25 4:07 ` [PATCH v6 2/4] powerpc/64: enhance memcmp() with VMX instruction for long bytes comparision wei.guo.simon
2018-05-28 11:05 ` Segher Boessenkool
2018-05-30 8:14 ` Simon Guo
2018-05-30 8:35 ` Segher Boessenkool
2018-05-30 9:03 ` Simon Guo
2018-06-06 6:42 ` Simon Guo
2018-06-06 20:00 ` Segher Boessenkool
2018-05-28 11:59 ` Michael Ellerman
2018-05-30 8:15 ` Simon Guo
2018-05-25 4:07 ` [PATCH v6 3/4] powerpc/64: add 32 bytes prechecking before using VMX optimization on memcmp() wei.guo.simon
2018-05-25 4:07 ` [PATCH v6 4/4] powerpc:selftest update memcmp_64 selftest for VMX implementation wei.guo.simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530082739.GF17342@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=cyrilbur@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=wei.guo.simon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.