All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jeff Moyer <jmoyer@redhat.com>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"bgurney@redhat.com" <bgurney@redhat.com>
Subject: Re: [PATCH 0/2][RFC] block: default to deadline for SMR devices
Date: Wed, 30 May 2018 01:47:53 -0700	[thread overview]
Message-ID: <20180530084753.GA29413@infradead.org> (raw)
In-Reply-To: <122bc1d9-a074-7282-6812-aba26f4868f4@wdc.com>

On Wed, May 30, 2018 at 06:22:04AM +0000, Damien Le Moal wrote:
> That would necessitate splitting elevator_init() into a generic elevator
> initialization function setting up the elevator related fields of the
> request queue and a second part setting up the default elevator (e.g.
> elevator_set_default()). Doing so, the function elevator_set_default()
> could be called later in the device initialization sequence, after
> information from the device has been obtained. It would make choosing a
> sane default elevator much cleaner.

For blk-mq this makes entirely sense, untested series here:

	http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/elevator_init

For the legacy case we always need at least some I/O scheduler,
so we can't just defer it.  But I think we could still switch to
deadline in blk_register_queue if we found a zoned device.

  reply	other threads:[~2018-05-30  8:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 21:14 [PATCH 0/2][RFC] block: default to deadline for SMR devices Jeff Moyer
2018-05-25 21:14 ` [PATCH 1/2] block: __elevator_change: add try_loading parameter Jeff Moyer
2018-05-25 21:14 ` [PATCH 2/2] block: default to deadline for host-managed SMR devices Jeff Moyer
2018-05-25 22:04 ` [PATCH 0/2][RFC] block: default to deadline for " Jens Axboe
2018-05-25 22:18   ` Jeff Moyer
2018-05-26  4:01     ` Jens Axboe
2018-05-29 12:14       ` Bryan Gurney
2018-05-30  6:22       ` Damien Le Moal
2018-05-30  8:47         ` Christoph Hellwig [this message]
2018-05-31  5:36           ` Damien Le Moal
2018-05-30 13:45         ` Bryan Gurney
2018-05-30  8:49       ` Christoph Hellwig
2018-05-30 14:22         ` Jens Axboe
2018-05-30 15:06           ` Jeff Moyer
2018-05-30 15:17             ` Jens Axboe
2018-05-30 15:45               ` Jeff Moyer
2018-05-30 15:52                 ` Jens Axboe
2018-05-31  3:16                   ` Damien Le Moal
2018-05-31  3:04                 ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530084753.GA29413@infradead.org \
    --to=hch@infradead.org \
    --cc=Damien.LeMoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=bgurney@redhat.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.