From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:55898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753718AbeE3UFM (ORCPT ); Wed, 30 May 2018 16:05:12 -0400 Date: Wed, 30 May 2018 22:04:51 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Guenter Roeck , stable Subject: Re: Patches for -stable to improve support for recent gcc versions Message-ID: <20180530200451.GA14464@kroah.com> References: <4c1fa1a9-b242-10e5-ce1d-89f04eb50fa7@roeck-us.net> <314932ef-7047-22e7-7b9b-ad8d52dfee0f@roeck-us.net> <20180530184645.GB7299@roeck-us.net> <20180530192435.GB29473@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Wed, May 30, 2018 at 09:34:34PM +0200, Arnd Bergmann wrote: > On Wed, May 30, 2018 at 9:24 PM, Greg Kroah-Hartman > > Why is that not an option enabled for all arches right now for gcc-8? > > I would still want this warning enabled by default in future kernels, > just disabled > for the system call definitions (until we decide to rework the way > they are defined). > > What I'd suggest we do is a series of patches: > > 1. disable both -Wno-attribute-alias and -Wstringop-truncation by > default, but leave them > enabled in 'make W=1'. Mark this one for stable backports > 2. add a macro to let users disable warnings locally within a file, > based on _Pragma("GCC > diagnostic ...") > 3. change the system call macros to disable -Wno-attribute-alias inside of the > SYSCALL_DEFINEx() macros > 4. turn on -Wno-attribute-alias again by default. That sounds like a good plan to me.