From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH rfc] nvme-pci: make sure to flush sqe writes before db record update
Date: Thu, 31 May 2018 07:47:39 +0200 [thread overview]
Message-ID: <20180531054739.GA30923@lst.de> (raw)
In-Reply-To: <84ebcf65-d1a2-2ee5-d4d7-b96d61ed3c16@grimberg.me>
On Thu, May 31, 2018@02:34:33AM +0300, Sagi Grimberg wrote:
> resurrecting this one...
>
> Can anyone say why this is _not_ needed?
>From Documentation/memory-barriers.txt in linux-next, where this was
discussed once more not too log ago:
Note that, when using writel(), a prior wmb() is not needed to guarantee
that the cache coherent memory writes have completed before writing to
the MMIO region.
next prev parent reply other threads:[~2018-05-31 5:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 17:56 [PATCH rfc] nvme-pci: make sure to flush sqe writes before db record update Sagi Grimberg
2018-03-08 7:56 ` Christoph Hellwig
2018-03-08 15:51 ` Keith Busch
2018-03-08 17:20 ` Jason Gunthorpe
2018-03-08 17:37 ` Keith Busch
2018-03-08 17:56 ` Sagi Grimberg
2018-03-08 18:36 ` Jason Gunthorpe
2018-03-08 18:42 ` Keith Busch
2018-05-30 23:34 ` Sagi Grimberg
2018-05-31 5:47 ` Christoph Hellwig [this message]
2018-05-31 7:53 ` Sagi Grimberg
2018-05-31 15:20 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531054739.GA30923@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.